From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34264C73C69 for ; Wed, 10 Jul 2019 04:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07D5620665 for ; Wed, 10 Jul 2019 04:03:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K1qh7Hcw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbfGJEDJ (ORCPT ); Wed, 10 Jul 2019 00:03:09 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38053 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbfGJEDJ (ORCPT ); Wed, 10 Jul 2019 00:03:09 -0400 Received: by mail-wr1-f68.google.com with SMTP id g17so933351wrr.5 for ; Tue, 09 Jul 2019 21:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E/+8WA5YVt9o68tf7IxaP2AKZIs3izvlH0APT6Mt07Q=; b=K1qh7HcwzDZLVDAhRFo1UMOBKQLz3oQjDqRwz2jFT38WMwz/Hl+vBRVpz6PZ8eyy3Y dTAmu29NVGAwAZMWL0pe9v9Be598VLNvCEXNI4Hmi9hk8iVCmDpiCn3DzAX+ya48+l5E agWdvXAgbkGVdffOYWAEPWEA5Tt1dpEYgqARMkGUm9CBA9Z7CDJCzkt8K2r4smVHL7vu IxMt0gyE+LkrWBBgHX7+Dm2eM7WrA3nvP7LdaYR5P8bZpqvhbzthPdfj/epTNYwzA56p AOfetMta9CkyUC4Q9MJQDe4yMoicmVktguXRf/xx872evRk4ahBKSIB/SR+PNbG029Rw 4ZUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E/+8WA5YVt9o68tf7IxaP2AKZIs3izvlH0APT6Mt07Q=; b=VHki5sYcQ8lHc1FbbKTVucx2Sqp2nBVq/TySMJy2W+27qpN7T3dnQY02PxCr7wA6IZ EMRFjRsJ2ugzAJtGfquhrxEHU3rC7KoufzwF8n85+C6E1CJc1htQG24J7zA0yfyXAXoo rlcsGENuFTR2msrGlrhtcGSYfg+iIW9u4C4BTkajR5qoEhHxA28mACgZsYms9bAh8utI UPvKt2qiwuY/DLxRk4zxSqh7ioXhZ8a8QCi0BWSPYhFIpaYOmpMQcZ1f/mteprm8qJfT Ze9heVuPxlD9AH31avs0kR+HawaTmULtPPqW7PLOFpQC6TKL6aSbl+C0eqH2K3KxAgMx PWfg== X-Gm-Message-State: APjAAAU36rC2TKxlZgf7c8x07l/9tum0F5YWhC02gXYp2UYE6SsAYUrj EYQcAC827CwpocGoK+Z2+gi0izyjF5lYg4VUj62nJA== X-Google-Smtp-Source: APXvYqzPOdmo7LUjjtBVy+Eam/jLKZXcN/T+ttk0oWQFmX0MgxeRc22swD1KsBEGZUN6nDxG/pwDPT36kLteJxt49zQ= X-Received: by 2002:a05:6000:145:: with SMTP id r5mr9063316wrx.208.1562731387533; Tue, 09 Jul 2019 21:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20190621095252.32307-1-vincenzo.frascino@arm.com> <20190621095252.32307-11-vincenzo.frascino@arm.com> In-Reply-To: <20190621095252.32307-11-vincenzo.frascino@arm.com> From: John Stultz Date: Tue, 9 Jul 2019 21:02:54 -0700 Message-ID: Subject: Re: [PATCH v7 10/25] arm64: compat: Add vDSO To: Vincenzo Frascino Cc: linux-arch@vger.kernel.org, linux-arm-kernel , lkml , linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Andre Przywara , Arnd Bergmann , Huw Davies , Catalin Marinas , Daniel Lezcano , Will Deacon , Russell King , Ralf Baechle , Mark Salyzyn , Paul Burton , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Thomas Gleixner , Shijith Thotton , Peter Collingbourne Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Jun 21, 2019 at 3:18 AM Vincenzo Frascino wrote: > > Provide the arm64 compat (AArch32) vDSO in kernel/vdso32 in a similar > way to what happens in kernel/vdso. > > The compat vDSO leverages on an adaptation of the arm architecture code > with few changes: > - Use of lib/vdso for gettimeofday > - Implementation of syscall based fallback > - Introduction of clock_getres for the compat library > - Implementation of trampolines > - Implementation of elf note > > To build the compat vDSO a 32 bit compiler is required and needs to be > specified via CONFIG_CROSS_COMPILE_COMPAT_VDSO. > Hey Vincenzo! Congrats on getting this work merged, I know its been a long effort over a number of years! Though unfortunately, it seems the arm64 vdso code that just landed is breaking AOSP for me. I see a lot of the following errors: 01-01 01:22:14.097 755 755 F libc : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 755 (cameraserver), pid 755 (cameraserver) 01-01 01:22:14.112 759 759 F libc : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 759 (android.hardwar), pid 759 (android.hardwar) 01-01 01:22:14.120 756 756 F libc : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 756 (drmserver), pid 756 (drmserver) Which go away if I revert the vdso merge that went in via tip/timers. I tried to bisect things down a bit, but as some later fixes are required (at one point, date was returning the start epoch and never increasing), this hasn't worked too well. But I'm guessing since I see: "CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built", and the system is half working, I'm guessing this is an issue with just the 32bit code failing. While I can try to sort out the proper CROSS_COMPILE_COMPAT in my build environment, I assume userland shouldn't be crashing if that value isn't set. Any chance this issue has already been raised? thanks -john