From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A191C433EF for ; Sat, 2 Oct 2021 09:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D722661037 for ; Sat, 2 Oct 2021 09:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232713AbhJBJ1G (ORCPT ); Sat, 2 Oct 2021 05:27:06 -0400 Received: from mail-vs1-f54.google.com ([209.85.217.54]:35694 "EHLO mail-vs1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232719AbhJBJZX (ORCPT ); Sat, 2 Oct 2021 05:25:23 -0400 Received: by mail-vs1-f54.google.com with SMTP id f18so14116319vsp.2; Sat, 02 Oct 2021 02:23:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lj27fX+w/X1fzAaixWVl+EMSmBzqib+t1AvqNPW0Qfo=; b=eQ7Xi9BjwHarBUNbWz9NkWr+Fq1PS//jsakctwN1H55+6xYfn/5LXwsCHrYFZTnUcN mwY9NJ2FfvWu3wmzbKuXrU4cXn5mqLsTR+efLwMLgNDEMAWvHqEkC1Ik1WFbgAvIz2Gx JuEmKDTYxqlB2l312wzigYfwJemW5sYFhCM0NfF9vpNfGv0hzOSF9UNhjuEdtnXfk9yU +JV7vk5s/EldK0mGmu9saoMP1nnYXQ8OPZdp5na8Mvyp8T5XCGp8apmtWP8pJ3+9C2/p Oz2qn2Q2SE80s6k8HBIQ6iGYUF6tBC1YlRtYk+B5o1q8F2GiFLEMTWrTF/w9WIiGgS8A 0qxw== X-Gm-Message-State: AOAM532FJKaFkA2ueioqhCgwtr7GJs9sIsBrPlBln+xYP93w8czVziVJ p4hIiGc02j1P9w0wLDl2qshMRPZ42IoTmnUuAeg= X-Google-Smtp-Source: ABdhPJyIkTe18axoKGGfe6/riaB8UL54KfoHPvrebxDva0p8GQNYtsCXNMqktxYUF4cWRNiUDZV6LfcDHAZk9sL3kO8= X-Received: by 2002:a67:c295:: with SMTP id k21mr5066492vsj.37.1633166617532; Sat, 02 Oct 2021 02:23:37 -0700 (PDT) MIME-Version: 1.0 References: <20211001181245.228419-1-yury.norov@gmail.com> <20211001181245.228419-4-yury.norov@gmail.com> In-Reply-To: <20211001181245.228419-4-yury.norov@gmail.com> From: Geert Uytterhoeven Date: Sat, 2 Oct 2021 11:23:26 +0200 Message-ID: Subject: Re: [PATCH 03/16] include: move find.h from asm_generic to linux To: Yury Norov Cc: Stephen Rothwell , Andrew Morton , Linux Kernel Mailing List , Linux MM , Linux-Arch , "open list:KERNEL SELFTEST FRAMEWORK" , Linux MMC List , linux-perf-users@vger.kernel.org, KVM list , "James E.J. Bottomley" , Alexander Lobakin , Alexander Shishkin , Alexey Klimov , Andrea Merello , Andy Shevchenko , Arnaldo Carvalho de Melo , Arnd Bergmann , Ben Gardon , Benjamin Herrenschmidt , Brian Cain , Catalin Marinas , Christoph Lameter , Daniel Bristot de Oliveira , David Hildenbrand , Dennis Zhou , Heiko Carstens , Ian Rogers , Ingo Molnar , Jaegeuk Kim , Jakub Kicinski , Jiri Olsa , Joe Perches , Jonas Bonn , Leo Yan , Mark Rutland , Namhyung Kim , Palmer Dabbelt , Paolo Bonzini , Peter Xu , Peter Zijlstra , Petr Mladek , Rasmus Villemoes , Rich Felker , Samuel Mendoza-Jonas , Sean Christopherson , Sergey Senozhatsky , Shuah Khan , Stefan Kristiansson , Steven Rostedt , Tejun Heo , Thomas Bogendoerfer , Ulf Hansson , Will Deacon , Wolfram Sang , Yoshinori Sato Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi Yuri, Thanks for your patch! On Fri, Oct 1, 2021 at 8:12 PM Yury Norov wrote: > find_bit API and bitmap API are closely related, but inclusion paths > are different - include/asm-generic and include/linux, correspondingly. > In the past it made a lot of troubles due to circular dependencies > and/or undefined symbols. Fix this by moving find.h under include/linux. .. and including it from include/linux/bitmap.h, like the other helper includes? > Signed-off-by: Yury Norov > Tested-by: Wolfram Sang > arch/m68k/include/asm/bitops.h | 2 -- Acked-by: Geert Uytterhoeven > --- a/include/linux/bitmap.h > +++ b/include/linux/bitmap.h > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > #include > #include Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds