From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D84CC35240 for ; Fri, 31 Jan 2020 14:55:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E788921734 for ; Fri, 31 Jan 2020 14:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bqZKRFmy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729113AbgAaOzG (ORCPT ); Fri, 31 Jan 2020 09:55:06 -0500 Received: from mail-yw1-f65.google.com ([209.85.161.65]:46565 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729062AbgAaOzF (ORCPT ); Fri, 31 Jan 2020 09:55:05 -0500 Received: by mail-yw1-f65.google.com with SMTP id z141so4426437ywd.13 for ; Fri, 31 Jan 2020 06:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SDj5kNjMiLc1TNHQMyijHY5lqlqUv2q9y5ctnKAZRBM=; b=bqZKRFmycIWRiGhpMQzPAIBZjoFVrYuo2SZLTiBQn9hk3BIfxPOgtiasQqrKsz2M5R xcr70sdeXtlmRgqAkxi4MwwCCGAkJhHqVAsDAT18gQB8K95aCL2+v7W3tf6GiQuTk9wx zSsFPc/QZmAsiQnT6xuRc+WOhhu4GLqhGs9PXg0H7dCfbwXXOUvKNyrwN6IBwhS4kjJP xqgIEUk70E2YY22PIZpKwKrFtorhvE2J/tl5xnCl5++MsQJJfl74Og7nGC7EhicDGutJ s6D889kI9JFG1is8ZQK56+B9Cjutnn92mtrnjX6fCu2blz9jNuBePoRzER6x6s+DTbFF UPKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SDj5kNjMiLc1TNHQMyijHY5lqlqUv2q9y5ctnKAZRBM=; b=dPvbu2fArGi3NfmFDKLMmrKF+Gxs85aOoI0xAj8hxPNdptVLEvHKaw4gk5h+E/a9Nc sJDGYGQSI/YAvv2Bx2D/VAJU3qKFSnkYt9r+tHSGbalY/zE5YZkjwizA9FMVmkODR25L YrqdnVEd91PqJu/SfHSFKF7Sg4zfhU21iiCmuki3hXTar2Vff41YxRKx5yXObC090895 esJr1PB9+RFbeu6+TTZvhDGWtctotmb89ZqUQqNe7jNn4biJcE86vC7Cl7hKRI2Ehkno Cto2EoN/8A86XM/tVOXk4PVxDvZ6AtYi/yn3yQ8NdGZaoJfv9wxV2pJCFnGw9WgHvvvN JhUg== X-Gm-Message-State: APjAAAW8M+C0uc/ug0x2WJtkeQ5dHQb8scZOVJNIIYOdZXq8gXlc1nV9 N7UkDyLiE7WOWGzcC+djHmS3i3BC5+1upKHA7Z77VA== X-Google-Smtp-Source: APXvYqyvp5cLvKH6z6kEMndeCtof01VGlsZXoDmYcGmrhf/gmPmDw9GCx5N5tQtW9+VSCDoYF9vhN4WVGMlTHp5v3c0= X-Received: by 2002:a25:d112:: with SMTP id i18mr8262683ybg.364.1580482504570; Fri, 31 Jan 2020 06:55:04 -0800 (PST) MIME-Version: 1.0 References: <20200131122421.23286-1-sjpark@amazon.com> <20200131122421.23286-2-sjpark@amazon.com> In-Reply-To: <20200131122421.23286-2-sjpark@amazon.com> From: Eric Dumazet Date: Fri, 31 Jan 2020 06:54:53 -0800 Message-ID: Subject: Re: [PATCH 1/3] net/ipv4/inet_timewait_sock: Fix inconsistent comments To: sjpark@amazon.com Cc: David Miller , Shuah Khan , netdev , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , sj38.park@gmail.com, aams@amazon.com, SeongJae Park Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Jan 31, 2020 at 4:24 AM wrote: > > From: SeongJae Park > > Commit ec94c2696f0b ("tcp/dccp: avoid one atomic operation for timewait > hashdance") mistakenly erased a comment for the second step of > `inet_twsk_hashdance()`. This commit restores it for better > readability. > > Signed-off-by: SeongJae Park > --- > net/ipv4/inet_timewait_sock.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c > index c411c87ae865..fbfcd63cc170 100644 > --- a/net/ipv4/inet_timewait_sock.c > +++ b/net/ipv4/inet_timewait_sock.c > @@ -120,6 +120,7 @@ void inet_twsk_hashdance(struct inet_timewait_sock *tw, struct sock *sk, > > spin_lock(lock); > > + /* Step 2: Hash TW into tcp ehash chain. */ This comment adds no value, please do not bring it back. net-next is closed, now is not the time for cosmetic changes. Also take a look at Documentation/networking/netdev-FAQ.rst