From: Marco Elver <elver@google.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Brendan Higgins <brendanhiggins@google.com>,
David Gow <davidgow@google.com>,
Arpitha Raghunandan <98.arpi@gmail.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Iurii Zaikin <yzaikin@google.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Bird, Tim" <Tim.Bird@sony.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH v9 1/2] kunit: Support for Parameterized Testing
Date: Wed, 2 Dec 2020 00:31:49 +0100 [thread overview]
Message-ID: <CANpmjNMOMD+2OhBWNh5XuFufbm1bhXTUm4Y3_YiNNdfC=G2xdQ@mail.gmail.com> (raw)
In-Reply-To: <505b8cd0-a61e-5ec3-7e0b-239d0ff55d56@linuxfoundation.org>
On Tue, 1 Dec 2020 at 23:28, Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 11/30/20 3:22 PM, Brendan Higgins wrote:
> > On Mon, Nov 23, 2020 at 11:25 PM David Gow <davidgow@google.com> wrote:
> >>
> >> On Mon, Nov 23, 2020 at 9:08 PM Marco Elver <elver@google.com> wrote:
> >>>
> >>> On Tue, 17 Nov 2020 at 08:21, David Gow <davidgow@google.com> wrote:
> >>>> On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.arpi@gmail.com> wrote:
> >>>>>
> >>>>> Implementation of support for parameterized testing in KUnit. This
> >>>>> approach requires the creation of a test case using the
> >>>>> KUNIT_CASE_PARAM() macro that accepts a generator function as input.
> >>>>>
> >>>>> This generator function should return the next parameter given the
> >>>>> previous parameter in parameterized tests. It also provides a macro to
> >>>>> generate common-case generators based on arrays. Generators may also
> >>>>> optionally provide a human-readable description of parameters, which is
> >>>>> displayed where available.
> >>>>>
> >>>>> Note, currently the result of each parameter run is displayed in
> >>>>> diagnostic lines, and only the overall test case output summarizes
> >>>>> TAP-compliant success or failure of all parameter runs. In future, when
> >>>>> supported by kunit-tool, these can be turned into subsubtest outputs.
> >>>>>
> >>>>> Signed-off-by: Arpitha Raghunandan <98.arpi@gmail.com>
> >>>>> Co-developed-by: Marco Elver <elver@google.com>
> >>>>> Signed-off-by: Marco Elver <elver@google.com>
> >>>>> ---
> >>>> [Resending this because my email client re-defaulted to HTML! Aarrgh!]
> >>>>
> >>>> This looks good to me! I tested it in UML and x86-64 w/ KASAN, and
> >>>> both worked fine.
> >>>>
> >>>> Reviewed-by: David Gow <davidgow@google.com>
> >>>> Tested-by: David Gow <davidgow@google.com>
> >>>
> >>> Thank you!
> >>>
> >>>> Thanks for sticking with this!
> >>>
> >>> Will these patches be landing in 5.11 or 5.12?
> >>>
> >>
> >> I can't think of any reason not to have these in 5.11. We haven't
> >> started staging things in the kselftest/kunit branch for 5.11 yet,
> >> though.
> >>
> >> Patch 2 will probably need to be acked by Ted for ext4 first.
> >>
> >> Brendan, Shuah: can you make sure this doesn't get lost in patchwork?
> >
> > Looks good to me. I would definitely like to pick this up. But yeah,
> > in order to pick up 2/2 we will need an ack from either Ted or Iurii.
> >
> > Ted seems to be busy right now, so I think I will just ask Shuah to go
> > ahead and pick this patch up by itself and we or Ted can pick up patch
> > 2/2 later.
> >
> > Cheers
> >
>
> I am seeing
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #272: FILE: include/kunit/test.h:1786:
> + typeof((array)[0]) *__next = prev ? ((typeof(__next)) prev) + 1 :
> (array); \
> ^
>
> Can you look into this and send v10?
This is a false positive. I pointed this out here before:
https://lkml.kernel.org/r/CANpmjNNhpe6TYt0KmBCCR-Wfz1Bxd8qnhiwegwnDQsxRAWmUMg@mail.gmail.com
checkpatch.pl thinks this is a multiplication, but this is a pointer,
so the spacing here is correct.
Thanks,
-- Marco
> thanks,
> -- Shuah
next prev parent reply other threads:[~2020-12-01 23:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 5:40 [PATCH v9 1/2] kunit: Support for Parameterized Testing Arpitha Raghunandan
2020-11-16 5:41 ` [PATCH v9 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature Arpitha Raghunandan
2020-11-16 8:51 ` Marco Elver
2020-11-17 7:22 ` David Gow
2020-12-01 20:30 ` Iurii Zaikin
2020-12-02 16:07 ` Theodore Y. Ts'o
2020-12-02 22:59 ` Shuah Khan
2020-11-16 8:53 ` [PATCH v9 1/2] kunit: Support for Parameterized Testing Marco Elver
2020-11-17 7:20 ` David Gow
2020-11-23 13:08 ` Marco Elver
2020-11-24 7:25 ` David Gow
2020-11-24 8:02 ` Marco Elver
2020-11-30 22:22 ` Brendan Higgins
2020-12-01 22:28 ` Shuah Khan
2020-12-01 23:31 ` Marco Elver [this message]
2020-12-02 22:58 ` Shuah Khan
2020-12-02 16:02 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANpmjNMOMD+2OhBWNh5XuFufbm1bhXTUm4Y3_YiNNdfC=G2xdQ@mail.gmail.com' \
--to=elver@google.com \
--cc=98.arpi@gmail.com \
--cc=Tim.Bird@sony.com \
--cc=adilger.kernel@dilger.ca \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).