From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F11C433FE for ; Thu, 16 Dec 2021 10:15:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235885AbhLPKPv (ORCPT ); Thu, 16 Dec 2021 05:15:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233244AbhLPKPv (ORCPT ); Thu, 16 Dec 2021 05:15:51 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CCD5C06173F for ; Thu, 16 Dec 2021 02:15:51 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id m6so35843442oim.2 for ; Thu, 16 Dec 2021 02:15:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0ccU4l2gWdShDsgwAqNEPDETHATnNwCJsPsDA5QgM/Y=; b=XmQdVhq0C17djmNUyj3wlktdoOKkm4eWzpJgohNUHt5GLOK704JRnPixIHTzxhjE35 L/aBvrCdvrH65uxrQMFkyWR0hklFlraRZb5ofI0XGS/Nw7p8PibJklH3GP8ghfTsAD5j RVnEORaekW+692xz/TgKoCMGN9PpgryF939/YRPg90wINRGgArl60phHyQbnDHVpq9T5 kid9x0EXIIU7pvFNJGeN3SEwJzltSu7Z8j9XX2kq2WQV+ohPynzlRlT5l/5N2eDl1xNv KaG0E6+FbRHY2VLcf7LREVBIm6WVyRKUkGX0gBDXtfh1co3O0HHML821/Wi5Js3S3IF/ Llrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0ccU4l2gWdShDsgwAqNEPDETHATnNwCJsPsDA5QgM/Y=; b=LVpDpfzxIhUVQjB+OCHqK1wb25fpPrf4KmueLgPrkDY83HczeXZ7uUxAVm8ZI1zJCn sMsv9xLExuWe3F7TCusQVyGg0ZzERpmpDiIDqzQWdgo12MYKweNy33aCESIjsqczf+cm 61oMrifF0xDh0aswcx+bYRTS6NRYpj2jsHS8wdyyiyWnniTJuz/tq0dvglkfqL24/SDY pf7S0pBEgZbIUX4NFG0M30PKZG25FvfbJU9jNS5PNorWe2IPSMEnKHL1X6auqhe8tr80 mZv6xPEaM4leqbucU+P5sI9XuhILCwSoWordaf+Ub+HW7jKTN0DeBWPketE927Md39Ik MZWg== X-Gm-Message-State: AOAM533RUAqCGCcVf6q22dA8VtpoK2Buva6SJO6eWPN7j9FxNN36svwo DF/Qk0onDh/EAnVBHAiUM4812b84jxvxcnE1njRrIg== X-Google-Smtp-Source: ABdhPJxBKV3JcsaI3lPlUvHwy9E03kvuSxr/FWXDJBdAzNWTsSfW08Cp4vy5XvLNdV3EDG4w9McVNvfhh7s/9A7J/K4= X-Received: by 2002:a05:6808:1903:: with SMTP id bf3mr3417400oib.7.1639649750354; Thu, 16 Dec 2021 02:15:50 -0800 (PST) MIME-Version: 1.0 References: <20211216055958.634097-1-sharinder@google.com> <20211216055958.634097-4-sharinder@google.com> In-Reply-To: <20211216055958.634097-4-sharinder@google.com> From: Marco Elver Date: Thu, 16 Dec 2021 11:15:38 +0100 Message-ID: Subject: Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture To: Harinder Singh Cc: davidgow@google.com, brendanhiggins@google.com, shuah@kernel.org, corbet@lwn.net, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Tim.Bird@sony.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, 16 Dec 2021 at 07:00, Harinder Singh wrote: > > Describe the components of KUnit and how the kernel mode parts > interact with kunit_tool. > > Signed-off-by: Harinder Singh > --- > .../dev-tools/kunit/architecture.rst | 204 ++++++++++++++++++ > Documentation/dev-tools/kunit/index.rst | 2 + > .../kunit/kunit_suitememorydiagram.png | Bin 0 -> 24174 bytes > Documentation/dev-tools/kunit/start.rst | 1 + > 4 files changed, 207 insertions(+) > create mode 100644 Documentation/dev-tools/kunit/architecture.rst > create mode 100644 Documentation/dev-tools/kunit/kunit_suitememorydiagram.png In response to the other email: Adding binary blobs just creates problems, for comparing different versions, and general bloating the whole repo, where better alternatives exist. I suppose an ASCII diagram is a bit primitive. :-) However, SVG files on the other hand are not binary blobs, they are text-markup based (XML), and e.g. diffing them often provides useful information about what changed. SVG also has the benefit of being vector graphics, and not being limited to one resolution. Looking at the diagram you added, I think this can easily be turned into vector graphics, and most likely will not use up 24KiB as a result. Thanks, -- Marco