From: <Tim.Bird@sony.com>
To: <arnd@arndb.de>, <brendanhiggins@google.com>
Cc: <gregkh@linuxfoundation.org>, <logang@deltatee.com>,
<sboyd@kernel.org>, <skhan@linuxfoundation.org>,
<linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] kunit: add PRINTK dependency
Date: Fri, 6 Sep 2019 15:31:02 +0000 [thread overview]
Message-ID: <ECADFF3FD767C149AD96A924E7EA6EAF977A9B7B@USCULXMSG01.am.sony.com> (raw)
In-Reply-To: <20190906152800.1662489-1-arnd@arndb.de>
Minor spelling nit..
> -----Original Message-----
> From: Arnd Bergmann
>
> The vprintk_emit() function is not available when CONFIG_PRINTK
> is disabled:
>
> kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-
> Werror,-Wimplicit-function-declaration]
>
> I suppose without printk(), there is not much use in kunit
> either, so add a Kconfig depenedency here.
depenedency -> dependency
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> kunit/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kunit/Kconfig b/kunit/Kconfig
> index 8541ef95b65a..e80d8af00454 100644
> --- a/kunit/Kconfig
> +++ b/kunit/Kconfig
> @@ -6,6 +6,7 @@ menu "KUnit support"
>
> config KUNIT
> bool "Enable support for unit tests (KUnit)"
> + depends on PRINTK
> help
> Enables support for kernel unit tests (KUnit), a lightweight unit
> testing and mocking framework for the Linux kernel. These tests are
> --
> 2.20.0
next prev parent reply other threads:[~2019-09-06 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:27 [PATCH] kunit: add PRINTK dependency Arnd Bergmann
2019-09-06 15:31 ` Tim.Bird [this message]
2019-09-06 15:39 ` Shuah Khan
2019-09-06 16:02 ` Arnd Bergmann
2019-09-06 16:08 ` Shuah Khan
2019-09-07 0:43 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ECADFF3FD767C149AD96A924E7EA6EAF977A9B7B@USCULXMSG01.am.sony.com \
--to=tim.bird@sony.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).