linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>
To: 'Reinette Chatre' <reinette.chatre@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>
Subject: RE: [PATCH v2 4/5] selftests/resctrl: Change default limited time to 120 seconds for resctrl_tests
Date: Fri, 21 Jan 2022 07:59:38 +0000	[thread overview]
Message-ID: <TYAPR01MB63301CABB489B1A764A9E8718B5B9@TYAPR01MB6330.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <c8fd3125-b61c-8182-d7af-0f7a85eba345@intel.com>

Hi Reinette,

> On 12/13/2021 2:01 AM, Shaopeng Tan wrote:
> > This commit changed the default limited time(45s) to 120 seconds for
> 
> (This commit)
> 
> > resctrl_tests by adding "setting" file.  Since 45 seconds may not be
> > enough on some machine environments.
> 
> This sounds very imprecise when you say "may not be enough". From what I
> understand you have already encountered systems where this is not enough so
> you have established that 45 seconds is too short. The next question is, how
> was 120 seconds determined and how do you know it will be enough?

It took about 68 seconds in my environment (Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz). 
This test accesses a fixed size(250M) memory by default settings 
which is used when run in kselftest framework. 
I think that the execution time does not change significantly in different environments.
So, I roughly doubled the execution time and get 120s, which I set to the limited time. 
I think it is enough for any environments.
If 120s are also not enough, user can freely set the limited time by "setting" file.

Thanks for your feedback of this patch series,
I will correct them in a few days.

> > Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> > ---
> >  tools/testing/selftests/resctrl/settings | 1 +
> >  1 file changed, 1 insertion(+)
> >  create mode 100644 tools/testing/selftests/resctrl/settings
> >
> > diff --git a/tools/testing/selftests/resctrl/settings
> > b/tools/testing/selftests/resctrl/settings
> > new file mode 100644
> > index 000000000000..6091b45d226b
> > --- /dev/null
> > +++ b/tools/testing/selftests/resctrl/settings
> > @@ -0,0 +1 @@
> > +timeout=120

Best regards,
Tan Shaopeng

  reply	other threads:[~2022-01-21  8:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 10:01 [PATCH v2 0/5] selftests/resctrl: Add resctrl_tests into kselftest set Shaopeng Tan
2021-12-13 10:01 ` [PATCH v2 1/5] selftests/resctrl: Kill the child process created by fork() when the SIGTERM signal comes Shaopeng Tan
2022-01-06 23:46   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 2/5] selftests/resctrl: Make resctrl_tests run using kselftest framework Shaopeng Tan
2022-01-06 23:48   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 3/5] selftests/resctrl: Add license to resctrl_test Makefile Shaopeng Tan
2022-01-06 23:49   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 4/5] selftests/resctrl: Change default limited time to 120 seconds for resctrl_tests Shaopeng Tan
2022-01-06 23:49   ` Reinette Chatre
2022-01-21  7:59     ` tan.shaopeng [this message]
2022-01-21 18:06       ` Reinette Chatre
2022-01-24  8:07         ` tan.shaopeng
2021-12-13 10:01 ` [PATCH v2 5/5] selftests/resctrl: Return KSFT_SKIP(4) if resctrlfile system is not supported or resctrl is not run as root Shaopeng Tan
2022-01-06 23:54   ` Reinette Chatre
2022-01-04  9:35 ` [PATCH v2 0/5] selftests/resctrl: Add resctrl_tests into kselftest set tan.shaopeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB63301CABB489B1A764A9E8718B5B9@TYAPR01MB6330.jpnprd01.prod.outlook.com \
    --to=tan.shaopeng@fujitsu.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).