From: Jiri Olsa <olsajiri@gmail.com>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, mykolal@fb.com, shuah@kernel.org,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH v2 0/6] Add _opts variant for bpf_*_get_fd_by_id()
Date: Fri, 7 Oct 2022 12:59:17 +0200 [thread overview]
Message-ID: <Y0AGhW4USeB4sHU3@krava> (raw)
In-Reply-To: <20221006110736.84253-1-roberto.sassu@huaweicloud.com>
On Thu, Oct 06, 2022 at 01:07:30PM +0200, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> Add the _opts variant for bpf_*_get_fd_by_id() functions, to be able to
> pass to the kernel more options, when requesting a fd of an eBPF object.
>
> Pass the options through a newly introduced structure,
> bpf_get_fd_by_id_opts, which currently contains open_flags (the other two
> members are for compatibility and for padding).
>
> open_flags allows the caller to request specific permissions to access a
> map (e.g. read-only). This is useful for example in the situation where a
> map is write-protected.
>
> Besides patches 2-6, which introduce the new variants and the data
> structure, patch 1 fixes the LIBBPF_1.0.0 declaration in libbpf.map.
>
> Changelog
>
> v1:
> - Don't CC stable kernel mailing list for patch 1 (suggested by Andrii)
> - Rename bpf_get_fd_opts struct to bpf_get_fd_by_id_opts (suggested by
> Andrii)
> - Move declaration of _opts variants after non-opts variants (suggested by
> Andrii)
> - Correctly initialize bpf_map_info, fix style issues, use map from
> skeleton, check valid fd in the test (suggested by Andrii)
> - Rename libbpf_get_fd_opts test to libbpf_get_fd_by_id_opts
>
> Roberto Sassu (6):
> libbpf: Fix LIBBPF_1.0.0 declaration in libbpf.map
> libbpf: Introduce bpf_get_fd_by_id_opts and
> bpf_map_get_fd_by_id_opts()
> libbpf: Introduce bpf_prog_get_fd_by_id_opts()
> libbpf: Introduce bpf_btf_get_fd_by_id_opts()
> libbpf: Introduce bpf_link_get_fd_by_id_opts()
> selftests/bpf: Add tests for _opts variants of bpf_*_get_fd_by_id()
it's not marked, but I'm assuming this goes to bpf-next, right?
anyway, lgtm
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> tools/lib/bpf/bpf.c | 48 +++++++++-
> tools/lib/bpf/bpf.h | 16 ++++
> tools/lib/bpf/libbpf.map | 6 +-
> tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
> .../bpf/prog_tests/libbpf_get_fd_by_id_opts.c | 87 +++++++++++++++++++
> .../bpf/progs/test_libbpf_get_fd_by_id_opts.c | 36 ++++++++
> 6 files changed, 189 insertions(+), 5 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/libbpf_get_fd_by_id_opts.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_libbpf_get_fd_by_id_opts.c
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-10-07 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 11:07 [PATCH v2 0/6] Add _opts variant for bpf_*_get_fd_by_id() Roberto Sassu
2022-10-06 11:07 ` [PATCH v2 1/6] libbpf: Fix LIBBPF_1.0.0 declaration in libbpf.map Roberto Sassu
2022-10-06 11:07 ` [PATCH v2 2/6] libbpf: Introduce bpf_get_fd_by_id_opts and bpf_map_get_fd_by_id_opts() Roberto Sassu
2022-10-06 11:07 ` [PATCH v2 3/6] libbpf: Introduce bpf_prog_get_fd_by_id_opts() Roberto Sassu
2022-10-06 11:07 ` [PATCH v2 4/6] libbpf: Introduce bpf_btf_get_fd_by_id_opts() Roberto Sassu
2022-10-06 11:07 ` [PATCH v2 5/6] libbpf: Introduce bpf_link_get_fd_by_id_opts() Roberto Sassu
2022-10-06 11:07 ` [PATCH v2 6/6] selftests/bpf: Add tests for _opts variants of bpf_*_get_fd_by_id() Roberto Sassu
2022-10-07 10:59 ` Jiri Olsa [this message]
2022-10-07 11:31 ` [PATCH v2 0/6] Add _opts variant for bpf_*_get_fd_by_id() Roberto Sassu
2022-10-11 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0AGhW4USeB4sHU3@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).