From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AAC2C433FE for ; Wed, 12 Oct 2022 10:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229490AbiJLKSp (ORCPT ); Wed, 12 Oct 2022 06:18:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbiJLKSg (ORCPT ); Wed, 12 Oct 2022 06:18:36 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8ACDD83; Wed, 12 Oct 2022 03:18:32 -0700 (PDT) Received: from zn.tnic (p200300ea9733e705329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e705:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7164D1EC0716; Wed, 12 Oct 2022 12:18:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1665569907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=9vYszipudkgN+JyCf6YKNcAINQz5USDy31mfIDJFVGs=; b=bUR2WL5WGtmu9OPZHEVmibMsQjRPSN5SwXgYgrqCOe0jXKGU2KDQpreiK48V4qekgiZppe s0JN83R33y7M7crVylIXvWaNvDc8w04mCNheyrlQGDPLUj29DN28b3l9Ca7K+lUhRcE39H vSjhbxAp+9WhMxnaXvNv1wgW/X1Krjs= Date: Wed, 12 Oct 2022 12:18:23 +0200 From: Borislav Petkov To: Kuppuswamy Sathyanarayanan Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Shuah Khan , Jonathan Corbet , "H . Peter Anvin" , Greg Kroah-Hartman , "Kirill A . Shutemov" , Tony Luck , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in driver module Message-ID: References: <20220928215535.26527-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220928215535.26527-2-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220928215535.26527-2-sathyanarayanan.kuppuswamy@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Sep 28, 2022 at 02:55:33PM -0700, Kuppuswamy Sathyanarayanan wrote: > To support TDX attestation, the TDX guest user interface driver must > use the __tdx module_call() function in the driver to allow the user to > obtain the TDREPORT. > > So export the __tdx_module_call() and move the TDX Module IDs to > asm/tdx.h. The functions with the __ prefix are usually lower-level interfaces which should be internal. Usually. Why aren't you exporting the tdx_module_call() one instead? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette