From: Greg KH <gregkh@linuxfoundation.org>
To: Jing Zhang <jingzhangos@google.com>
Cc: KVM <kvm@vger.kernel.org>, KVMARM <kvmarm@lists.cs.columbia.edu>,
LinuxMIPS <linux-mips@vger.kernel.org>,
KVMPPC <kvm-ppc@vger.kernel.org>,
LinuxS390 <linux-s390@vger.kernel.org>,
Linuxkselftest <linux-kselftest@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>,
Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
David Rientjes <rientjes@google.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
David Matlack <dmatlack@google.com>,
Ricardo Koller <ricarkol@google.com>,
Krish Sadhukhan <krish.sadhukhan@oracle.com>,
Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface
Date: Thu, 17 Jun 2021 08:07:36 +0200 [thread overview]
Message-ID: <YMrmqOxDWJ2/8sfD@kroah.com> (raw)
In-Reply-To: <20210617044146.2667540-4-jingzhangos@google.com>
On Thu, Jun 17, 2021 at 04:41:44AM +0000, Jing Zhang wrote:
> This new API provides a file descriptor for every VM and VCPU to read
> KVM statistics data in binary format.
> It is meant to provide a lightweight, flexible, scalable and efficient
> lock-free solution for user space telemetry applications to pull the
> statistics data periodically for large scale systems. The pulling
> frequency could be as high as a few times per second.
> The statistics descriptors are defined by KVM in kernel and can be
> by userspace to discover VM/VCPU statistics during the one-time setup
> stage.
> The statistics data itself could be read out by userspace telemetry
> periodically without any extra parsing or setup effort.
Do you have a pointer to userspace code that can do such a thing that
others can use? We do not like adding apis to the kernel without at
least seeing the user of those apis, especially for complex things like
this.
Ideally you would include some library code in the kernel tree itself
that everyone can use for this for their own programs. You have
provided a test which is great, but how do we know it works for "real"
usages?
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-17 6:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 4:41 [PATCH v10 0/5] KVM statistics data fd-based binary interface Jing Zhang
2021-06-17 4:41 ` [PATCH v10 1/5] KVM: stats: Separate generic stats from architecture specific ones Jing Zhang
2021-06-17 4:41 ` [PATCH v10 2/5] KVM: stats: Add fd-based API to read binary stats data Jing Zhang
2021-06-17 7:03 ` Greg KH
2021-06-17 11:23 ` Paolo Bonzini
2021-06-17 14:48 ` Jing Zhang
2021-06-17 7:24 ` Greg KH
2021-06-17 11:27 ` Paolo Bonzini
2021-06-17 14:56 ` Jing Zhang
2021-06-17 15:29 ` Paolo Bonzini
2021-06-17 15:42 ` Jing Zhang
2021-06-17 4:41 ` [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface Jing Zhang
2021-06-17 5:52 ` Greg KH
2021-06-17 15:09 ` Jing Zhang
2021-06-17 5:56 ` Greg KH
2021-06-17 11:29 ` Paolo Bonzini
2021-06-17 11:42 ` Greg KH
2021-06-17 11:46 ` Paolo Bonzini
2021-06-17 15:45 ` Jing Zhang
2021-06-17 15:20 ` Jing Zhang
2021-06-17 22:15 ` Jing Zhang
2021-06-17 6:05 ` Greg KH
2021-06-17 15:41 ` Jing Zhang
2021-06-17 6:07 ` Greg KH [this message]
2021-06-17 11:19 ` Paolo Bonzini
2021-06-17 11:34 ` Greg KH
2021-06-17 15:51 ` Jing Zhang
2021-06-17 4:41 ` [PATCH v10 4/5] KVM: selftests: Add selftest for KVM statistics data binary interface Jing Zhang
2021-06-17 4:41 ` [PATCH v10 5/5] KVM: stats: Remove code duplication for binary and debugfs stats Jing Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMrmqOxDWJ2/8sfD@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmatlack@google.com \
--cc=eesposit@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=jmattson@google.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=ricarkol@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=tsbogend@alpha.franken.de \
--cc=vkuznets@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).