From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA59C433F5 for ; Mon, 6 Dec 2021 13:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244842AbhLFNxM (ORCPT ); Mon, 6 Dec 2021 08:53:12 -0500 Received: from mga07.intel.com ([134.134.136.100]:26242 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244804AbhLFNxM (ORCPT ); Mon, 6 Dec 2021 08:53:12 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10189"; a="300699248" X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="300699248" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 05:49:43 -0800 X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="678988796" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 05:49:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1muEMB-002nVh-Ul; Mon, 06 Dec 2021 15:48:39 +0200 Date: Mon, 6 Dec 2021 15:48:39 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Kent Gibson , Linus Walleij , Shuah Khan , Geert Uytterhoeven , Viresh Kumar , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v12 3/7] gpiolib: of: make fwnode take precedence in struct gpio_chip Message-ID: References: <20211203133003.31786-1-brgl@bgdev.pl> <20211203133003.31786-4-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Dec 06, 2021 at 02:40:36PM +0100, Bartosz Golaszewski wrote: > On Mon, Dec 6, 2021 at 2:34 PM Andy Shevchenko > wrote: > > > > On Mon, Dec 06, 2021 at 09:41:33AM +0100, Bartosz Golaszewski wrote: > > > On Fri, Dec 3, 2021 at 9:10 PM Andy Shevchenko > > > wrote: > > > > ... > > > > > This series concerns the gpio-sim driver and it only uses configfs > > > (with manually created platform devices) or device-tree. I would > > > prefer to do ACPI separately and I'd like you to lead that because I > > > neither have any HW to test nor claim to understand it. :) > > > > Please, mention this in the commit message that ACPI is not covered (yet). > > But the commit message says: "gpiolib: of: make fwnode take precedence > in struct gpio_chip" - it says OF right here. :) It implies that reader should have a 6th sense to know about ACPI and what else? Please, be explicit over implicit. -- With Best Regards, Andy Shevchenko