From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B3E0C32771 for ; Wed, 21 Sep 2022 21:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiIUVev (ORCPT ); Wed, 21 Sep 2022 17:34:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbiIUVeu (ORCPT ); Wed, 21 Sep 2022 17:34:50 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DE1722B2F for ; Wed, 21 Sep 2022 14:34:47 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id w13so6966566plp.1 for ; Wed, 21 Sep 2022 14:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=ub8WoIp0abwg5liI/4m3sr2tp4uNXD4t2ehf1q0m6wg=; b=rI69Q9BxoaDNtd+yWlZdfd+fLCbIpU5l5ao+Rqz6oNxaztS8WYRZ7USrQzybEMX/J5 HnzZQB+IkaY8nNo7h2ZITrqeQhQsuESoCahu8Ri6DqXg4vDap2DWllz9wHznYSylG3A2 C4hzGwMMEoYzYmQuryvK+M6OqJJRukDB9Q14eD9oLl4CVImKRw5f2+d51qlDTD/UcPki q7zfFIjk4krXqAv4kygLKoKyyToFNuhYbf5FG2GQ81HJexLELBpRwSWhhCI5qxkTHIN1 /PH4HgGiLr/RdxMGvuZoAdbzC9Yvp35uxcAMAMXkMoqmsOYxKLzb/XMiJsVK0XUHToBq EOlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=ub8WoIp0abwg5liI/4m3sr2tp4uNXD4t2ehf1q0m6wg=; b=C4EypjyfwD99qCtd6qmglSJzt2F2Y7mA5x9EeVUN9qyM9nwSERvDWDjlI0qta0PsPT zE4DAb1GjtxzKtYitwMBW3hN/uKDTBJNzs555dV9scoRfZv4YvH8JJh4S/IEVk4zawI7 Z/hQ26h1IEwl43qWO+h5T/5qQN316SYMP6D4AF2BohE5FbtZ+kKZI/yAOrx0XsO/GoNB iHFh2dKCjRszK0NCq4tbsvSzu9B5EbTND/sTwDLd1geo3SZIW9nNES1MIP+4N+TfwEeH JPwRDBWJdCNFYUF3B/GGMTbFplH8z8c7K9egMAsojgZVbURsBMRhZTvj3qzlggZgr79v cdUQ== X-Gm-Message-State: ACrzQf1OxzDrHva6eVeIw2gTCjzZDES0H9Fppc0OqEQpOTVGNKZQLQlp BmEF5X7gDkyG19nDZshikttvEA== X-Google-Smtp-Source: AMsMyM5lEMgDklRZQsljsr+7PkZGmwHNKrhKQUZF9rpjOG3q6Xu1U2q2NjkwtKsQqkLF+khDK/H6AQ== X-Received: by 2002:a17:903:41c6:b0:178:348e:f760 with SMTP id u6-20020a17090341c600b00178348ef760mr177373ple.123.1663796086674; Wed, 21 Sep 2022 14:34:46 -0700 (PDT) Received: from google.com (223.103.125.34.bc.googleusercontent.com. [34.125.103.223]) by smtp.gmail.com with ESMTPSA id p124-20020a62d082000000b0053e3ed14419sm2683886pfg.48.2022.09.21.14.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 14:34:46 -0700 (PDT) Date: Wed, 21 Sep 2022 14:34:41 -0700 From: David Matlack To: Vishal Annapurve Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org, bgardon@google.com, seanjc@google.com, oupton@google.com, peterx@redhat.com, vkuznets@redhat.com Subject: Re: [V2 PATCH 5/8] KVM: selftests: x86: delete svm_vmcall_test Message-ID: References: <20220915000448.1674802-1-vannapurve@google.com> <20220915000448.1674802-6-vannapurve@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220915000448.1674802-6-vannapurve@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Sep 15, 2022 at 12:04:45AM +0000, Vishal Annapurve wrote: > svm_vmcall_test is superseded by fix_hypercall_test. Please provide a more detailed description of why svm_vmcall_test is being dropped. e.g. What do you mean by "superseded" specifically? I ask because this will be helpful context for future readers of this commit. I also ask because it's not clear to me that fix_hypercall_test is a 1:1 replacement of svm_vmcall_test. e.g. svm_vmcall_test sets up an L2 while fix_hypercall_test just executes in L1. > > Suggested-by: Sean Christopherson > Signed-off-by: Vishal Annapurve > --- > tools/testing/selftests/kvm/.gitignore | 1 - > .../selftests/kvm/x86_64/svm_vmcall_test.c | 74 ------------------- > 2 files changed, 75 deletions(-) > delete mode 100644 tools/testing/selftests/kvm/x86_64/svm_vmcall_test.c > > diff --git a/tools/testing/selftests/kvm/.gitignore b/tools/testing/selftests/kvm/.gitignore > index d625a3f83780..22e9a5b5488c 100644 > --- a/tools/testing/selftests/kvm/.gitignore > +++ b/tools/testing/selftests/kvm/.gitignore > @@ -36,7 +36,6 @@ > /x86_64/sev_migrate_tests > /x86_64/smm_test > /x86_64/state_test > -/x86_64/svm_vmcall_test > /x86_64/svm_int_ctl_test > /x86_64/svm_nested_soft_inject_test > /x86_64/sync_regs_test > diff --git a/tools/testing/selftests/kvm/x86_64/svm_vmcall_test.c b/tools/testing/selftests/kvm/x86_64/svm_vmcall_test.c > deleted file mode 100644 > index c3ac45df7483..000000000000 > --- a/tools/testing/selftests/kvm/x86_64/svm_vmcall_test.c > +++ /dev/null > @@ -1,74 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * svm_vmcall_test > - * > - * Copyright (C) 2020, Red Hat, Inc. > - * > - * Nested SVM testing: VMCALL > - */ > - > -#include "test_util.h" > -#include "kvm_util.h" > -#include "processor.h" > -#include "svm_util.h" > - > -static void l2_guest_code(struct svm_test_data *svm) > -{ > - __asm__ __volatile__("vmcall"); > -} > - > -static void l1_guest_code(struct svm_test_data *svm) > -{ > - #define L2_GUEST_STACK_SIZE 64 > - unsigned long l2_guest_stack[L2_GUEST_STACK_SIZE]; > - struct vmcb *vmcb = svm->vmcb; > - > - /* Prepare for L2 execution. */ > - generic_svm_setup(svm, l2_guest_code, > - &l2_guest_stack[L2_GUEST_STACK_SIZE]); > - > - run_guest(vmcb, svm->vmcb_gpa); > - > - GUEST_ASSERT(vmcb->control.exit_code == SVM_EXIT_VMMCALL); > - GUEST_DONE(); > -} > - > -int main(int argc, char *argv[]) > -{ > - struct kvm_vcpu *vcpu; > - vm_vaddr_t svm_gva; > - struct kvm_vm *vm; > - > - TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SVM)); > - > - vm = vm_create_with_one_vcpu(&vcpu, l1_guest_code); > - > - vcpu_alloc_svm(vm, &svm_gva); > - vcpu_args_set(vcpu, 1, svm_gva); > - > - for (;;) { > - volatile struct kvm_run *run = vcpu->run; > - struct ucall uc; > - > - vcpu_run(vcpu); > - TEST_ASSERT(run->exit_reason == KVM_EXIT_IO, > - "Got exit_reason other than KVM_EXIT_IO: %u (%s)\n", > - run->exit_reason, > - exit_reason_str(run->exit_reason)); > - > - switch (get_ucall(vcpu, &uc)) { > - case UCALL_ABORT: > - REPORT_GUEST_ASSERT(uc); > - /* NOT REACHED */ > - case UCALL_SYNC: > - break; > - case UCALL_DONE: > - goto done; > - default: > - TEST_FAIL("Unknown ucall 0x%lx.", uc.cmd); > - } > - } > -done: > - kvm_vm_free(vm); > - return 0; > -} > -- > 2.37.2.789.g6183377224-goog >