From: Sean Christopherson <seanjc@google.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] KVM: selftests: Use TAP interface in the kvm_binary_stats_test
Date: Fri, 7 Oct 2022 01:22:26 +0000 [thread overview]
Message-ID: <Yz9/UsWtYimt2T1D@google.com> (raw)
In-Reply-To: <20221005083312.dnblbpe6wabspkzk@kamzik>
On Wed, Oct 05, 2022, Andrew Jones wrote:
> On Tue, Oct 04, 2022 at 11:31:29AM +0200, Thomas Huth wrote:
> > The kvm_binary_stats_test test currently does not have any output (unless
> > one of the TEST_ASSERT statement fails), so it's hard to say for a user
> > how far it did proceed already. Thus let's make this a little bit more
> > user-friendly and include some TAP output via the kselftest.h interface.
>
> I like the idea of switching the entire kvm selftests framework and all
> tests to the ksft TAP interface. But, if we want to do that, then the
> question is whether we should start by partially using it for some tests,
> and then eventually switch over the framework, or whether we should try to
> switch everything at once.
>
> I think I prefer the latter, because without changing the framework we
> can't provide full TAP anyway as TEST_ASSERT exits with 254 instead of 1
> for a fail-exit and it doesn't output a final TAP test summary either.
I would much prefer the latter, e.g. with common entry/exit points[*], much of the
boilerplate can be done once in common code. I bet we could even figure out a way
to have tests default to setting a plan of '1' so that simple tests don't need to
care about TAP at all.
[*] https://lore.kernel.org/all/20220915000448.1674802-2-vannapurve@google.com
next prev parent reply other threads:[~2022-10-07 1:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 9:31 [RFC PATCH 0/3] Use TAP in some more KVM selftests Thomas Huth
2022-10-04 9:31 ` [PATCH 1/3] KVM: selftests: Use TAP interface in the kvm_binary_stats_test Thomas Huth
2022-10-05 8:33 ` Andrew Jones
2022-10-07 1:22 ` Sean Christopherson [this message]
2022-10-04 9:31 ` [PATCH 2/3] KVM: selftests: x86: Use TAP interface in the sync_regs test Thomas Huth
2022-10-04 9:31 ` [PATCH 3/3] KVM: selftests: x86: Use TAP interface in the tsc_msrs_test Thomas Huth
2022-10-14 21:03 ` [RFC PATCH 0/3] Use TAP in some more KVM selftests Sean Christopherson
2022-11-08 1:06 ` David Matlack
2022-11-09 19:22 ` Sean Christopherson
2022-11-10 7:45 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz9/UsWtYimt2T1D@google.com \
--to=seanjc@google.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).