From: shuah <firstname.lastname@example.org> To: Joe Perches <email@example.com>, Dan Carpenter <firstname.lastname@example.org> Cc: David Gow <email@example.com>, Brendan Higgins <firstname.lastname@example.org>, Andrew Morton <email@example.com>, Kees Cook <firstname.lastname@example.org>, "open list:KERNEL SELFTEST FRAMEWORK" <email@example.com>, firstname.lastname@example.org, email@example.com, shuah <firstname.lastname@example.org> Subject: Re: [PATCH linux-kselftest/test v6] lib/list-test: add a test for the 'list' doubly linked list Date: Fri, 1 Nov 2019 10:49:51 -0600 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 10/30/19 1:23 PM, Joe Perches wrote: > On Wed, 2019-10-30 at 22:12 +0300, Dan Carpenter wrote: >> On Wed, Oct 30, 2019 at 10:27:12AM -0600, shuah wrote: >>>> It's better to ignore checkpatch and other scripts when they are wrong. >>>> (unless the warning message inspires you to make the code more readable >>>> for humans). >>>> >>> >>> It gets confusing when to ignore and when not to. It takes work to >>> figure out and it is subjective. >>> >> >> In this case, it's not subjective because checkpatch is clearly not >> working as intended. > > checkpatch _is_ working as intended. > It was never intended to be perfect. > > checkpatch _always_ depended on a reviewer deciding > whether its output was appropriate. > >> I don't feel like "checkpatch clean" is a useful criteria for applying >> patches. > > Nor do I. > >> The other things about warnings is that I always encourage people to >> just ignore old warnings. If you're running Smatch and you see a >> warning in ancient code that means I saw it five years ago and didn't >> fix it so it's a false positive. Old warnings are always 100% false >> positives. > > That'd be not absolute either because it depended on your > historical judgment as to whether an old warning was in fact > a defect or not. > > People make mistakes. > Regex based scripts are by design stupid and untrustworthy. > > Mistakes will be made. > Just fix the actual defects in code as soon as possible. > > > Thanks all for chiming in. I am taking v6 as is and adding an update to commit log capture the spurious errors from checkpath.pl for this specific case. thanks, -- Shuah
next prev parent reply other threads:[~2019-11-01 16:50 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-24 22:46 David Gow 2019-10-29 13:00 ` shuah 2019-10-30 8:02 ` David Gow 2019-10-30 10:42 ` Dan Carpenter 2019-10-30 16:27 ` shuah 2019-10-30 16:35 ` Brendan Higgins 2019-10-30 17:18 ` Joe Perches 2019-10-31 8:51 ` Brendan Higgins 2019-10-31 10:07 ` Joe Perches 2019-10-31 10:20 ` Dan Carpenter 2019-10-30 18:46 ` Dan Carpenter 2019-10-30 19:15 ` Joe Perches 2019-10-31 6:59 ` Dan Carpenter 2019-11-01 10:50 ` Rasmus Villemoes 2019-10-30 19:12 ` Dan Carpenter 2019-10-30 19:23 ` Joe Perches 2019-10-31 7:12 ` David Gow 2019-10-31 7:42 ` Dan Carpenter 2019-11-01 16:49 ` shuah [this message] 2019-10-30 16:31 ` Joe Perches 2019-10-31 18:50 ` Kees Cook 2019-11-01 10:25 ` David Gow
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH linux-kselftest/test v6] lib/list-test: add a test for the '\''list'\'' doubly linked list' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).