From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Shuah Khan <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"H . Peter Anvin" <hpa@zytor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Tony Luck <tony.luck@intel.com>, Kai Huang <kai.huang@intel.com>,
Wander Lairson Costa <wander@redhat.com>,
Isaku Yamahata <isaku.yamahata@gmail.com>,
marcelo.cerri@canonical.com, tim.gardner@canonical.com,
khalid.elmously@canonical.com, philip.cox@canonical.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v14 2/3] virt: Add TDX guest driver
Date: Wed, 12 Oct 2022 16:01:31 -0700 [thread overview]
Message-ID: <adc0987a-70f5-4203-c741-978d7d89cf76@linux.intel.com> (raw)
In-Reply-To: <Y0bhkVYfYhzkmrjp@zn.tnic>
On 10/12/22 8:47 AM, Borislav Petkov wrote:
> On Wed, Sep 28, 2022 at 02:55:34PM -0700, Kuppuswamy Sathyanarayanan wrote:
>> +static long tdx_get_report(void __user *argp)
>> +{
>> + u8 *reportdata, *tdreport;
>> + struct tdx_report_req req;
>> + long ret;
>> +
>> + if (copy_from_user(&req, argp, sizeof(req)))
>> + return -EFAULT;
>> +
>> + /*
>> + * Per TDX Module 1.0 specification, section titled
>> + * "TDG.MR.REPORT", REPORTDATA length is fixed as
>> + * TDX_REPORTDATA_LEN, TDREPORT length is fixed as
>> + * TDX_REPORT_LEN, and TDREPORT subtype is fixed as 0.
>> + */
>> + if (req.subtype || req.rpd_len != TDX_REPORTDATA_LEN ||
>> + req.tdr_len != TDX_REPORT_LEN)
>> + return -EINVAL;
>> +
>> + if (memchr_inv(req.reserved, 0, sizeof(req.reserved)))
>
> I'm guessing we should issue something here to userspace to let it know
> why the it fails getting the report.
I am fine with adding an error message here. What about the above -EINVAL
case? Do you suggest adding it there as well?
>
> Otherwise it is starting to look good and boring. :)
>
> Thx.
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2022-10-12 23:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 21:55 [PATCH v14 0/3] Add TDX Guest Attestation support Kuppuswamy Sathyanarayanan
2022-09-28 21:55 ` [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in driver module Kuppuswamy Sathyanarayanan
2022-10-12 10:18 ` Borislav Petkov
2022-10-12 13:35 ` Sathyanarayanan Kuppuswamy
2022-10-12 14:27 ` Borislav Petkov
2022-10-12 15:44 ` Sathyanarayanan Kuppuswamy
2022-10-12 16:23 ` Greg Kroah-Hartman
2022-10-12 17:13 ` Sathyanarayanan Kuppuswamy
2022-10-12 17:26 ` Greg Kroah-Hartman
2022-10-12 18:11 ` Sathyanarayanan Kuppuswamy
2022-09-28 21:55 ` [PATCH v14 2/3] virt: Add TDX guest driver Kuppuswamy Sathyanarayanan
2022-09-29 18:02 ` Wander Lairson Costa
2022-09-29 18:11 ` Sathyanarayanan Kuppuswamy
2022-09-30 12:22 ` Greg Kroah-Hartman
2022-09-30 15:27 ` Sathyanarayanan Kuppuswamy
2022-10-12 15:47 ` Borislav Petkov
2022-10-12 23:01 ` Sathyanarayanan Kuppuswamy [this message]
2022-10-13 13:21 ` Borislav Petkov
2022-09-28 21:55 ` [PATCH v14 3/3] selftests: tdx: Test TDX attestation GetReport support Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc0987a-70f5-4203-c741-978d7d89cf76@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@gmail.com \
--cc=kai.huang@intel.com \
--cc=khalid.elmously@canonical.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mingo@redhat.com \
--cc=philip.cox@canonical.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).