From: Alan Maguire <alan.maguire@oracle.com>
To: shuah <shuah@kernel.org>
Cc: Alan Maguire <alan.maguire@oracle.com>,
brendanhiggins@google.com, frowand.list@gmail.com,
gregkh@linuxfoundation.org, corbet@lwn.net,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
kunit-dev@googlegroups.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH v7 kunit-next 3/4] kunit: subtests should be indented 4 spaces according to TAP
Date: Wed, 25 Mar 2020 22:03:52 +0000 (GMT) [thread overview]
Message-ID: <alpine.LRH.2.21.2003252202360.25268@localhost> (raw)
In-Reply-To: <dd82e9cb-6c88-58cf-933e-f2a644e09b15@kernel.org>
On Wed, 25 Mar 2020, shuah wrote:
> On 3/13/20 8:44 AM, Alan Maguire wrote:
> > Introduce KUNIT_INDENT macro which corresponds to 4-space indentation,
> > and use it to modify indentation from tab to 4 spaces.
> >
> > Suggested-by: Frank Rowand <frowand.list@gmail.com>
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > Reviewed-by: Frank Rowand <frank.rowand@sony.com>
> > ---
> > include/kunit/test.h | 7 +++-
> > lib/kunit/assert.c | 79
> > +++++++++++++++++++------------------
> > lib/kunit/test.c | 6 +--
> > tools/testing/kunit/kunit_parser.py | 10 ++---
> > 4 files changed, 54 insertions(+), 48 deletions(-)
> >
> > diff --git a/include/kunit/test.h b/include/kunit/test.h
> > index f7b2ed4c..d49cdb4 100644
> > --- a/include/kunit/test.h
> > +++ b/include/kunit/test.h
> > @@ -84,6 +84,10 @@ struct kunit_resource {
> > /* Size of log associated with test. */
> > #define KUNIT_LOG_SIZE 512
> >
> > +/* TAP specifies subtest indentation of 4 spaces. */
> > +#define KUNIT_INDENT " "
> > +#define KUNIT_INDENT2 KUNIT_INDENT KUNIT_INDENT
>
> Sorry for a late comment on this.
>
> What's the reason to do it this way? Why wouldn't you define
> it as 8 spaces long string?
>
I could have I suppose; I thought it makes it a bit easier
to read as above (though it did generate a checkpatch
warning; I thought readability was more important in this
case, but I can alter if needed).
> Also can you please make sure to run checkpatch --strict on the
> patches you send?
>
Sure! There were also some other line-too-long warnings
generated as a result of this patch, but when I fixed those
checkpatch complained about splitting strings across multiple
lines. The only way out was to reduce the amount of information
in the log messages, which I didn't want to do. In future I can
note checkpatch warnings that I couldn't find a way to fix in the
commit message if that would help?
Thanks for taking a look!
Alan
> thanks,
> -- Shuah
>
>
next prev parent reply other threads:[~2020-03-25 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 14:44 [PATCH v7 kunit-next 0/4] kunit: add debugfs representation to show results Alan Maguire
2020-03-13 14:44 ` [PATCH v7 kunit-next 1/4] kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display Alan Maguire
2020-03-13 14:44 ` [PATCH v7 kunit-next 2/4] kunit: add log test Alan Maguire
2020-03-13 14:44 ` [PATCH v7 kunit-next 3/4] kunit: subtests should be indented 4 spaces according to TAP Alan Maguire
2020-03-14 0:00 ` Brendan Higgins
2020-03-25 20:05 ` shuah
2020-03-25 22:03 ` Alan Maguire [this message]
2020-03-25 22:11 ` shuah
2020-03-13 14:44 ` [PATCH v7 kunit-next 4/4] kunit: update documentation to describe debugfs representation Alan Maguire
2020-03-14 0:03 ` [PATCH v7 kunit-next 0/4] kunit: add debugfs representation to show results Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.2003252202360.25268@localhost \
--to=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).