From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0AEC433DF for ; Mon, 15 Jun 2020 16:33:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8ADE62078A for ; Mon, 15 Jun 2020 16:33:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="C4AOwykj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730426AbgFOQdy (ORCPT ); Mon, 15 Jun 2020 12:33:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729792AbgFOQdx (ORCPT ); Mon, 15 Jun 2020 12:33:53 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DBBCC05BD43 for ; Mon, 15 Jun 2020 09:33:53 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id y9so8030506qvs.4 for ; Mon, 15 Jun 2020 09:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=DyQ9X+CHS1SbCZvi5JD/ErZwYHtp+v8iH4fr/ScY52w=; b=C4AOwykjBsPT6pKnY+hXtp39Kmr6gtq4gDm7K6Z74U+ZNCtJOjUSpj3bIH7cVR0LqA RoUCurTh+rURQM/ZR4ygWRtfhmA3n5kfffLc01eIxcj/0aGRqIsOBkT8sUb77MAJK7Xz OisRXR8OKn0QIEwELDc6BQRhqPFD6TzrM5N0LL1nQ/jourBpdnQEIcN3FwU+UiSL6124 6fXFxhrWHCldh1IadWF3LiIoZqJ53nP4vYa9P7hzytZuWUmWBLeld32fOcD409DHI7pG qWnWAnhnR0sXkwSifTAQBdmrLNL0SiGig78/sn9Qx25FgP6/vFjj9J1CQjvmtzqS+gkX 7Waw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=DyQ9X+CHS1SbCZvi5JD/ErZwYHtp+v8iH4fr/ScY52w=; b=M37vKnP7RrERw4R3s5oUoI5CrdXl/A/DsE7GfemsCmF2OsZSCk/8tSyKCbTWNnQBUA KtrD3U6bMjxUxM0PAVt2r459r9txhHWNSwAMMLTSwDhi3WehVkwNjZhqVdi5n0qldSpX 8h7Mlp+uHfkmoVsnknuwR0rbIRbOubBhwUR/Cb9HHHL/Rg+sFJam2B7kBMaJY29xVn5O j5Fs4qszbSD1hW8roosjP0Y1XKb2XVnJsfdglvWLzT8GF3k2Roo75KQmODbtOLjKswi6 bQUpTJnwo/sEoANDEcMS3fLo/tEzQg/L/pFBVaPp99lJTpG1gP4IqqC6bz+i+1CHjw+I ervw== X-Gm-Message-State: AOAM5319s0QxMg50wQVWofGO6xdlYZbaBygtWEIm1OiK/AeCO/XFXfhE dkPOsk0gQQFwQZpYf9djXVIqrA== X-Google-Smtp-Source: ABdhPJyO/43VFF1QL1zf8f7VKdmUjzSRiSNFeHxeop6ApwS13C/gHwt/b15Uc/m5ORglfdyrvvI8Vw== X-Received: by 2002:a0c:e9cd:: with SMTP id q13mr26164373qvo.23.1592238832266; Mon, 15 Jun 2020 09:33:52 -0700 (PDT) Received: from bbking.lan ([2804:14c:4a5:36c::cd2]) by smtp.gmail.com with ESMTPSA id h19sm10770272qkl.49.2020.06.15.09.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 09:33:51 -0700 (PDT) Message-ID: Subject: Re: [PATCH] lib: kunit_test_overflow: add KUnit test of check_*_overflow functions From: Vitor Massaru Iha To: David Gow Cc: KUnit Development , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Brendan Higgins , linux-kernel-mentees@lists.linuxfoundation.org, Kees Cook , linux@rasmusvillemoes.dk Date: Mon, 15 Jun 2020 13:33:48 -0300 In-Reply-To: References: <20200611215501.213058-1-vitor@massaru.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Sat, 2020-06-13 at 14:56 +0800, David Gow wrote: > On Fri, Jun 12, 2020 at 5:55 AM Vitor Massaru Iha > wrote: > > This adds the convertion of the runtime tests of check_*_overflow > > fuctions, > > from `lib/test_overflow.c`to KUnit tests. > > Nit: couple of minor typos here: convertion -> conversion, and > functions -> functions > > > The log similar to the one seen in dmesg running test_overflow can > > be > > seen in `test.log`. > > > > Signed-off-by: Vitor Massaru Iha > > I've tested that this builds and runs on my system, and it all seems > to be working fine! > > Tested-by: David Gow > > > --- > > lib/Kconfig.debug | 17 ++ > > lib/Makefile | 1 + > > lib/kunit_overflow_test.c | 590 > > ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 608 insertions(+) > > create mode 100644 lib/kunit_overflow_test.c > > Echoing what Brendan and Kees mentioned, it'd be nicer to have this > replace the existing test, both because there's no need for redundant > tests (one will get out-of-date), and so that we can have a nice diff > showing the changes made as part of the conversion. > > Cheers, > -- David Thank you David, I will fix your suggestions.