linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
	Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] selftests/resctrl: Return KSFT_SKIP(4) if resctrlfile system is not supported or resctrl is not run as root
Date: Thu, 6 Jan 2022 15:54:17 -0800	[thread overview]
Message-ID: <b46ca792-d83d-9d07-3a31-876be74c76c4@intel.com> (raw)
In-Reply-To: <20211213100154.180599-6-tan.shaopeng@jp.fujitsu.com>

Hi Shaopeng Tan,

Subject line still with typo. Also, what does "resctrl is not run as root"
mean? Do you mean "resctrl_tests"? The subject line can be made more succinct
while the details are moved to the commit message.

On 12/13/2021 2:01 AM, Shaopeng Tan wrote:
> To unify the return code of resctrl_tests with the return code of
> selftest set, return KSFT_SKIP (4) if resctrl file system is not
> supported or resctrl is not run as root.

Please review the feedback I provided to your first version. I do not
see the explanation of how changing ksft_exit_fail_msg() to 
ksft_exit_skip() accomplishes the goal of unifying the return code.
It surely is not a good use of my time to review patches and have the
feedback ignored.

> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 973f09a66e1e..3be0895c492b 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -205,7 +205,7 @@ int main(int argc, char **argv)
>  	 * 2. We execute perf commands
>  	 */
>  	if (geteuid() != 0)
> -		return ksft_exit_fail_msg("Not running as root, abort testing.\n");
> +		return ksft_exit_skip("Not running as root, abort testing.\n");
>  
>  	/* Detect AMD vendor */
>  	detect_amd();
> @@ -235,7 +235,7 @@ int main(int argc, char **argv)
>  	sprintf(bm_type, "fill_buf");
>  
>  	if (!check_resctrlfs_support())
> -		return ksft_exit_fail_msg("resctrl FS does not exist\n");
> +		return ksft_exit_skip("resctrl FS does not exist\n");
>  
>  	filter_dmesg();
>  

Reinette

  reply	other threads:[~2022-01-06 23:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 10:01 [PATCH v2 0/5] selftests/resctrl: Add resctrl_tests into kselftest set Shaopeng Tan
2021-12-13 10:01 ` [PATCH v2 1/5] selftests/resctrl: Kill the child process created by fork() when the SIGTERM signal comes Shaopeng Tan
2022-01-06 23:46   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 2/5] selftests/resctrl: Make resctrl_tests run using kselftest framework Shaopeng Tan
2022-01-06 23:48   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 3/5] selftests/resctrl: Add license to resctrl_test Makefile Shaopeng Tan
2022-01-06 23:49   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 4/5] selftests/resctrl: Change default limited time to 120 seconds for resctrl_tests Shaopeng Tan
2022-01-06 23:49   ` Reinette Chatre
2022-01-21  7:59     ` tan.shaopeng
2022-01-21 18:06       ` Reinette Chatre
2022-01-24  8:07         ` tan.shaopeng
2021-12-13 10:01 ` [PATCH v2 5/5] selftests/resctrl: Return KSFT_SKIP(4) if resctrlfile system is not supported or resctrl is not run as root Shaopeng Tan
2022-01-06 23:54   ` Reinette Chatre [this message]
2022-01-04  9:35 ` [PATCH v2 0/5] selftests/resctrl: Add resctrl_tests into kselftest set tan.shaopeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b46ca792-d83d-9d07-3a31-876be74c76c4@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tan.shaopeng@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).