From: shuah <shuah@kernel.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
pbonzini@redhat.com, linux-kernel@vger.kernel.org,
drjones@redhat.com, sean.j.christopherson@intel.com,
linux-kselftest@vger.kernel.org, kvm@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests: kvm: Adding config fragments
Date: Wed, 7 Aug 2019 09:52:27 -0600 [thread overview]
Message-ID: <b6b4f179-1fef-65db-8125-fa60e3627656@kernel.org> (raw)
In-Reply-To: <20190807135814.12906-1-naresh.kamboju@linaro.org>
Hi Naresh,
On 8/7/19 7:58 AM, Naresh Kamboju wrote:
> selftests kvm test cases need pre-required kernel configs for the test
> to get pass.
>
Can you elaborate and add more information on which tests fail without
these configs. I am all for adding configs, however I would like to
see more information explaining which tests don't pass without this
change.
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> ---
> tools/testing/selftests/kvm/config | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 tools/testing/selftests/kvm/config
>
> diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config
> new file mode 100644
> index 000000000000..63ed533f73d6
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/config
> @@ -0,0 +1,3 @@
> +CONFIG_KVM=y
> +CONFIG_KVM_INTEL=y
> +CONFIG_KVM_AMD=y
>
That being said, it is up to Paolo to decide a call on this patch.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-08-07 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 13:58 [PATCH v2] selftests: kvm: Adding config fragments Naresh Kamboju
2019-08-07 15:52 ` shuah [this message]
2019-08-07 16:19 ` Paolo Bonzini
2019-08-07 16:25 ` shuah
2019-08-08 12:31 Naresh Kamboju
2019-08-08 15:10 ` Andrew Jones
2019-08-08 16:00 ` Paolo Bonzini
2019-08-09 7:35 ` Naresh Kamboju
2019-08-09 7:27 ` Naresh Kamboju
2019-08-08 17:22 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6b4f179-1fef-65db-8125-fa60e3627656@kernel.org \
--to=shuah@kernel.org \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).