From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A5DC32751 for ; Wed, 7 Aug 2019 15:52:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAC5D22297 for ; Wed, 7 Aug 2019 15:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565193160; bh=t56h21KNASqJFrwBf8iDFQutW8Xbq368HNoCUfPaANw=; h=Subject:To:References:From:Date:In-Reply-To:List-ID:From; b=P+6CRM5slPWFsiNhLaQm0dPltcRJ97Mwda+0EDUtX7dKq3L61vHXfNHjMBNE1P1yD 6XYFvvbXyRE23IWx0z9CbkoV/X7wl7cTOKWdJTADS6xF5EGWCyDacl4fTKHVkxh5I2 0nCQKVXyeOFh1JbwZq6QCgJNHPqGuL/gXJ6ezjws= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388783AbfHGPwk (ORCPT ); Wed, 7 Aug 2019 11:52:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:42126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388779AbfHGPwk (ORCPT ); Wed, 7 Aug 2019 11:52:40 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6421F21E73; Wed, 7 Aug 2019 15:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565193160; bh=t56h21KNASqJFrwBf8iDFQutW8Xbq368HNoCUfPaANw=; h=Subject:To:References:From:Date:In-Reply-To:From; b=LkdVjXB2jDNMFwA/lkPddhSh8C/yg3ibIcujkqsbH+3FJ86d7KtaM0IPpKnaVIJBR 1zhaF4EPIFntFV2NxHJs7RpQ+JDSyu84jla6yPYqKWMlU0EuqJxCVGt61UkOXrCjqE Y/U+EdOLVJ3DYcFE5Vf5cX878Vt9s5GCziIkRlfY= Subject: Re: [PATCH v2] selftests: kvm: Adding config fragments To: Naresh Kamboju , pbonzini@redhat.com, linux-kernel@vger.kernel.org, drjones@redhat.com, sean.j.christopherson@intel.com, linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, shuah References: <20190807135814.12906-1-naresh.kamboju@linaro.org> From: shuah Message-ID: Date: Wed, 7 Aug 2019 09:52:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190807135814.12906-1-naresh.kamboju@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi Naresh, On 8/7/19 7:58 AM, Naresh Kamboju wrote: > selftests kvm test cases need pre-required kernel configs for the test > to get pass. > Can you elaborate and add more information on which tests fail without these configs. I am all for adding configs, however I would like to see more information explaining which tests don't pass without this change. > Signed-off-by: Naresh Kamboju > --- > tools/testing/selftests/kvm/config | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 tools/testing/selftests/kvm/config > > diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config > new file mode 100644 > index 000000000000..63ed533f73d6 > --- /dev/null > +++ b/tools/testing/selftests/kvm/config > @@ -0,0 +1,3 @@ > +CONFIG_KVM=y > +CONFIG_KVM_INTEL=y > +CONFIG_KVM_AMD=y > That being said, it is up to Paolo to decide a call on this patch. thanks, -- Shuah