From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A0CC35653 for ; Fri, 21 Feb 2020 11:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD8B62073A for ; Fri, 21 Feb 2020 11:27:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=isovalent-com.20150623.gappssmtp.com header.i=@isovalent-com.20150623.gappssmtp.com header.b="Rlb6YHpD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726976AbgBUL1Y (ORCPT ); Fri, 21 Feb 2020 06:27:24 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40462 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726395AbgBUL1Y (ORCPT ); Fri, 21 Feb 2020 06:27:24 -0500 Received: by mail-wr1-f65.google.com with SMTP id t3so1617865wru.7 for ; Fri, 21 Feb 2020 03:27:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ho6wZMX8qLHipLihEaU5SCXs4HqK1+rvVl2GBlxkV28=; b=Rlb6YHpDPsOHCT/5Aq+PoY+c+yfNFB3uMTnFGqhvRhPm/D5NrdKzM2J4yQZgdKqvmx R3mnvee3YG//8uDOK6/gczMozK6zfg7E/WaLz1cTmuQA1EjTlNw+gnZVC8kRrK4hoX8O zQbdVR2pLVrnL8k6j6S2Q9RAaef0UQNxFqRGWx6Emo3FwOQUhNoXB5MbNebYDQ+n6jRP nToI6ez0LqEUnco25hj/dxmMpLh9JlG50ygHNaC4JWxAsnVW47V1MAXRpzpNVjz+QlaG oPHGFpzAi02xmB2wYd9gVJwG0LXWot9zDHJ9VvSz9hwf2DEUlAage1mxQbjNvaSyjMuz bSOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ho6wZMX8qLHipLihEaU5SCXs4HqK1+rvVl2GBlxkV28=; b=EMlIRIKGXqM2DGIsWFVgV9vwPYNp35EdiKx8EGHWIaBRoRJQvIy/bxni9GFAiwxqQ6 KNWZpdR/7xbz2THKJMydoaXvfc2H/0GoQ5WWS+kwsXo0IyOmBqK7ADOpT767EtW+J7V4 JPhFOMxXaSWCKUpVooTCD5X+Jz6uOxTAAcpS4JDd7zBbb0KHk86caNugKf9lAz1Vhyjf TjjXRuyoUnpGmKHchB4TpUW+JvVNDsiECUbx9xRA3HTuCXlYvld2/Sz2Nu0V9dcLZxCs qgCDzI/oN2wDYosIZUInEMdM3UNmUGBcZp2mxd2XXoSoW3uyvWvm6xFNooAO8nZ/LxQ3 voWA== X-Gm-Message-State: APjAAAUS+xDVUwrSTdX6j98rOEtJYcKYvHbhTT+O14pf5+x0+m8YNLfH +QQ23v01aJrL+KZbScyYoaOmnEL+ubB5wQ== X-Google-Smtp-Source: APXvYqylZ7Vhu0XF5ow5n1qsv1lD6lrch6MbYz9kBc0cMwAxD5rPbQ8q+Hj1YgY+26WTbyqFs1usTQ== X-Received: by 2002:a5d:474d:: with SMTP id o13mr47350622wrs.309.1582284440977; Fri, 21 Feb 2020 03:27:20 -0800 (PST) Received: from [192.168.1.23] ([91.143.66.155]) by smtp.gmail.com with ESMTPSA id v15sm3768573wrf.7.2020.02.21.03.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2020 03:27:20 -0800 (PST) Subject: Re: [PATCH bpf-next v2 1/5] bpftool: Move out sections to separate functions To: Michal Rostecki , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Quentin Monnet , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , "David S. Miller" , Jesper Dangaard Brouer , John Fastabend , "open list:KERNEL SELFTEST FRAMEWORK" References: <20200221031702.25292-1-mrostecki@opensuse.org> <20200221031702.25292-2-mrostecki@opensuse.org> From: Quentin Monnet Message-ID: Date: Fri, 21 Feb 2020 11:27:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200221031702.25292-2-mrostecki@opensuse.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org 2020-02-21 04:16 UTC+0100 ~ Michal Rostecki > Remove all calls of print_end_then_start_section function and for loops > out from the do_probe function. Instead, provide separate functions for > each section (like i.e. section_helpers) which are called in do_probe. > This change is motivated by better readability. > > Signed-off-by: Michal Rostecki Thanks! Reviewed-by: Quentin Monnet