From: Joe Perches <joe@perches.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: shuah <shuah@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
David Gow <davidgow@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH linux-kselftest/test v6] lib/list-test: add a test for the 'list' doubly linked list
Date: Thu, 31 Oct 2019 03:07:12 -0700 [thread overview]
Message-ID: <bd76d5c22f389f3e6ecc2575e32c906f79647765.camel@perches.com> (raw)
In-Reply-To: <20191031085129.GA217570@google.com>
On Thu, 2019-10-31 at 01:51 -0700, Brendan Higgins wrote:
> On Wed, Oct 30, 2019 at 10:18:44AM -0700, Joe Perches wrote:
> > On Wed, 2019-10-30 at 09:35 -0700, Brendan Higgins wrote:
> > > Agreed. I can see the point of not wanting to write an exception into
> > > checkpatch for every exception of it's general rules; however, it
> > > would be nice if there was a way to maybe have a special comment or
> > > something that could turn off a checkpatch error. That way, a
> > > checkpatch error/warning always means some action should be taken, and
> > > if a rule is being ignored, there is always documentation as to why.
> >
> > That couldn't work when a comment which may exist
> > in a file is out of scope of the patch context.
>
> Sorry, I don't understand exactly what you mean. Can you elaborate?
checkpatch works on patch contexts.
If the comment is not within the patch context,
checkpatch cannot ignore various test.
> static void list_test_list_for_each_prev(struct kunit *test) /* checkpatch: disable=for-each-format */
Long line, now what?
next prev parent reply other threads:[~2019-10-31 10:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 22:46 David Gow
2019-10-29 13:00 ` shuah
2019-10-30 8:02 ` David Gow
2019-10-30 10:42 ` Dan Carpenter
2019-10-30 16:27 ` shuah
2019-10-30 16:35 ` Brendan Higgins
2019-10-30 17:18 ` Joe Perches
2019-10-31 8:51 ` Brendan Higgins
2019-10-31 10:07 ` Joe Perches [this message]
2019-10-31 10:20 ` Dan Carpenter
2019-10-30 18:46 ` Dan Carpenter
2019-10-30 19:15 ` Joe Perches
2019-10-31 6:59 ` Dan Carpenter
2019-11-01 10:50 ` Rasmus Villemoes
2019-10-30 19:12 ` Dan Carpenter
2019-10-30 19:23 ` Joe Perches
2019-10-31 7:12 ` David Gow
2019-10-31 7:42 ` Dan Carpenter
2019-11-01 16:49 ` shuah
2019-10-30 16:31 ` Joe Perches
2019-10-31 18:50 ` Kees Cook
2019-11-01 10:25 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd76d5c22f389f3e6ecc2575e32c906f79647765.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=brendanhiggins@google.com \
--cc=dan.carpenter@oracle.com \
--cc=davidgow@google.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--subject='Re: [PATCH linux-kselftest/test v6] lib/list-test: add a test for the '\''list'\'' doubly linked list' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).