From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52955C11D00 for ; Fri, 21 Feb 2020 00:52:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29F37206EF for ; Fri, 21 Feb 2020 00:52:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Qa/xiybL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729476AbgBUAw1 (ORCPT ); Thu, 20 Feb 2020 19:52:27 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:39284 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729365AbgBUAw1 (ORCPT ); Thu, 20 Feb 2020 19:52:27 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01L0mFqs130067; Fri, 21 Feb 2020 00:52:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=2MiF4dVUkc3MWcos/LfkCVZBhlj/IhF6lAwfrxFDkGk=; b=Qa/xiybLHd9cEcexFOZ9pJSEyObVBONrKnMXTPyepXmHtEcZ0bI8S2QysIO7RX225It1 GV6xK+t8Os/XZwfWhTLbjC6Y4kkhaGDG/WWkfcGy4Prfan1HaRuVt2b0kdQmLopqCsmM jpTBHsFVTPUPxXj2f7xrUhrV2qCPNQi7mqZywiB1bbt4Uoe2Yc+YYxYxWq1+PAg1yz/g m1aaox0KZqCxqI32t4HD7dImClbktug79H6ia/EQsHGSGazTd3BNaO7pb/Pwtimq+OFP jyR/2voIMwtNuCNLAHav/1Da3gWJce50nOQjUvZf8zCL+9QGDNtHBmUridNFR37s0lCa xw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2y8ud1ddep-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Feb 2020 00:52:20 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01L0m0ML055753; Fri, 21 Feb 2020 00:52:19 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2y8ud7d62h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Feb 2020 00:52:19 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01L0qILt004986; Fri, 21 Feb 2020 00:52:18 GMT Received: from [192.168.1.206] (/71.63.128.209) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 20 Feb 2020 16:52:18 -0800 Subject: Re: [PATCH v12 8/9] hugetlb_cgroup: Add hugetlb_cgroup reservation tests To: Mina Almasry Cc: shuah@kernel.org, rientjes@google.com, shakeelb@google.com, gthelen@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, sandipan@linux.ibm.com References: <20200211213128.73302-1-almasrymina@google.com> <20200211213128.73302-8-almasrymina@google.com> From: Mike Kravetz Message-ID: Date: Thu, 20 Feb 2020 16:52:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200211213128.73302-8-almasrymina@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9537 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210003 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9537 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 mlxlogscore=999 clxscore=1011 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210003 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 2/11/20 1:31 PM, Mina Almasry wrote: > The tests use both shared and private mapped hugetlb memory, and > monitors the hugetlb usage counter as well as the hugetlb reservation > counter. They test different configurations such as hugetlb memory usage > via hugetlbfs, or MAP_HUGETLB, or shmget/shmat, and with and without > MAP_POPULATE. > > Also add test for hugetlb reservation reparenting, since this is > a subtle issue. > > Signed-off-by: Mina Almasry > Cc: sandipan@linux.ibm.com Thanks for adding the tests. At a high level, I do not see any issues. Acked-by: Mike Kravetz -- Mike Kravetz