From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FBBC433FE for ; Sat, 8 Oct 2022 11:34:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbiJHLeY (ORCPT ); Sat, 8 Oct 2022 07:34:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiJHLeX (ORCPT ); Sat, 8 Oct 2022 07:34:23 -0400 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59D9247B99; Sat, 8 Oct 2022 04:34:19 -0700 (PDT) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 1067E1884502; Sat, 8 Oct 2022 11:34:17 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 062492503DE3; Sat, 8 Oct 2022 11:34:17 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id F11D99120FED; Sat, 8 Oct 2022 11:34:16 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Sat, 08 Oct 2022 13:34:16 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 net-next 9/9] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests In-Reply-To: References: <20220928150256.115248-1-netdev@kapio-technology.com> <20220928150256.115248-10-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 2022-10-03 15:40, Ido Schimmel wrote: >> +locked_port_station_move() >> +{ >> + local mac=a0:b0:c0:c0:b0:a0 >> + >> + RET=0 >> + check_locked_port_support || return 0 >> + >> + bridge link set dev $swp1 locked on > > It is quite pointless to check that an entry cannot roam to a port that > has learning disabled... Need: > > bridge link set dev $swp1 locked on learning on > >> + >> + $MZ $h1 -q -t udp -a $mac -b rand >> + bridge fdb show dev $swp1 | grep "$mac vlan 1" | grep -q "master >> br0" > > bridge fdb get ... > > Same in other places > It seems that the output of 'bridge fdb get' does not respect the dev it is given as input and outputs the (MAC,vlan) when found on another dev...