From: "Liu, Jingqi" <jingqi.liu@intel.com>
To: Yi Liu <yi.l.liu@intel.com>, <joro@8bytes.org>,
<alex.williamson@redhat.com>, <jgg@nvidia.com>,
<kevin.tian@intel.com>, <robin.murphy@arm.com>,
<baolu.lu@linux.intel.com>
Cc: <cohuck@redhat.com>, <eric.auger@redhat.com>,
<nicolinc@nvidia.com>, <kvm@vger.kernel.org>,
<mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
<yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
<jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
<lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH v2 5/5] iommu/vt-d: Add nested domain support
Date: Mon, 13 Mar 2023 21:51:27 +0800 [thread overview]
Message-ID: <c6e7e0b6-454b-c4c9-e21b-dab68db00b21@intel.com> (raw)
In-Reply-To: <20230309082207.612346-6-yi.l.liu@intel.com>
On 3/9/2023 4:22 PM, Yi Liu wrote:
> From: Lu Baolu <baolu.lu@linux.intel.com>
>
> This adds nested domain support in the Intel IOMMU driver. It allows to
> allocate and free a nested domain, set the nested domain to a device,
> and synchronize the caches when the userspace managed page tables are
> updated.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
> drivers/iommu/intel/Makefile | 2 +-
> drivers/iommu/intel/iommu.c | 38 ++++++----
> drivers/iommu/intel/iommu.h | 15 ++++
> drivers/iommu/intel/nested.c | 143 +++++++++++++++++++++++++++++++++++
> 4 files changed, 182 insertions(+), 16 deletions(-)
> create mode 100644 drivers/iommu/intel/nested.c
[...]
> +
> +struct iommu_domain *intel_nested_domain_alloc(struct iommu_domain *s2_domain,
> + const void *user_data)
> +{
> + const struct iommu_hwpt_intel_vtd *vtd = user_data;
> + struct dmar_domain *domain;
> +
Would it be better to add the following check ?
if (WARN_ON(!user_data))
return NULL;
> + domain = kzalloc(sizeof(*domain), GFP_KERNEL_ACCOUNT);
> + if (!domain)
> + return NULL;
> +
> + domain->use_first_level = true;
> + domain->s2_domain = to_dmar_domain(s2_domain);
> + domain->s1_pgtbl = vtd->pgtbl_addr;
> + domain->s1_cfg = *vtd;
> + domain->domain.ops = &intel_nested_domain_ops;
> + domain->domain.type = IOMMU_DOMAIN_NESTED;
> + INIT_LIST_HEAD(&domain->devices);
> + spin_lock_init(&domain->lock);
> + xa_init(&domain->iommu_array);
> +
> + return &domain->domain;
> +}
Thanks,
Jingqi
next prev parent reply other threads:[~2023-03-13 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 8:22 [PATCH v2 0/5] Add Intel VT-d nested translation Yi Liu
2023-03-09 8:22 ` [PATCH v2 1/5] iommufd: Add nesting related data structures for Intel VT-d Yi Liu
2023-03-15 13:50 ` Liu, Jingqi
2023-03-21 6:31 ` Liu, Yi L
2023-03-20 13:49 ` Jason Gunthorpe
2023-03-21 6:06 ` Liu, Yi L
2023-03-09 8:22 ` [PATCH v2 2/5] iommu/vt-d: Implement hw_info for iommu capability query Yi Liu
2023-03-09 8:22 ` [PATCH v2 3/5] iommu/vt-d: Extend dmar_domain to support nested domain Yi Liu
2023-03-20 13:54 ` Jason Gunthorpe
2023-03-21 1:58 ` Baolu Lu
2023-03-09 8:22 ` [PATCH v2 4/5] iommu/vt-d: Add helper to setup pasid nested translation Yi Liu
2023-03-09 8:22 ` [PATCH v2 5/5] iommu/vt-d: Add nested domain support Yi Liu
2023-03-13 13:51 ` Liu, Jingqi [this message]
[not found] ` <bf434709-4bb3-a7bd-4b5a-9f495bd3a104@intel.com>
2023-03-14 1:21 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6e7e0b6-454b-c4c9-e21b-dab68db00b21@intel.com \
--to=jingqi.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).