From: shuah <shuah@kernel.org>
To: Kees Cook <keescook@chromium.org>, SeongJae Park <sjpark@amazon.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
sj38.park@gmail.com, SeongJae Park <sjpark@amazon.de>,
shuah <shuah@kernel.org>
Subject: Re: [PATCH 1/2] kselftest/runner: Print new line in print of timeout log
Date: Wed, 11 Dec 2019 10:19:50 -0700 [thread overview]
Message-ID: <cbbe2517-06bc-36c4-8762-a2cd28fa1e4a@kernel.org> (raw)
In-Reply-To: <201912071047.E373E19A97@keescook>
On 12/7/19 11:47 AM, Kees Cook wrote:
> On Mon, Dec 02, 2019 at 12:42:20PM +0100, SeongJae Park wrote:
>> From: SeongJae Park <sjpark@amazon.de>
>>
>> If a timeout failure occurs, kselftest kills the test process and prints
>> the timeout log. If the test process has killed while printing a log
>> that ends with new line, the timeout log can be printed in middle of the
>> test process output so that it can be seems like a comment, as below:
>>
>> # test_process_log not ok 3 selftests: timers: nsleep-lat # TIMEOUT
>>
>> This commit avoids such problem by printing one more line before the
>> TIMEOUT failure log.
>>
>> Signed-off-by: SeongJae Park <sjpark@amazon.de>
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> Cool, yeah, this looks fine to me. Nice idea!
>
> -Kees
>
>> ---
>> tools/testing/selftests/kselftest/runner.sh | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
>> index 84de7bc74f2c..a8d20cbb711c 100644
>> --- a/tools/testing/selftests/kselftest/runner.sh
>> +++ b/tools/testing/selftests/kselftest/runner.sh
>> @@ -79,6 +79,7 @@ run_one()
>> if [ $rc -eq $skip_rc ]; then \
>> echo "not ok $test_num $TEST_HDR_MSG # SKIP"
>> elif [ $rc -eq $timeout_rc ]; then \
>> + echo "#"
>> echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT"
>> else
>> echo "not ok $test_num $TEST_HDR_MSG # exit=$rc"
>> --
>> 2.17.1
>>
>
Thanks. Applying to fixes for the next 5.5-rc
-- Shuah
prev parent reply other threads:[~2019-12-11 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 11:42 [PATCH 1/2] kselftest/runner: Print new line in print of timeout log SeongJae Park
2019-12-02 11:42 ` [PATCH 2/2] kselftest: Support old perl versions SeongJae Park
2019-12-07 18:47 ` Kees Cook
2019-12-11 17:20 ` shuah
2019-12-06 19:31 ` [PATCH 1/2] kselftest/runner: Print new line in print of timeout log SeongJae Park
2019-12-07 18:47 ` Kees Cook
2019-12-11 17:19 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbbe2517-06bc-36c4-8762-a2cd28fa1e4a@kernel.org \
--to=shuah@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).