From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09DC0C4363A for ; Mon, 26 Oct 2020 18:19:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9F5322281 for ; Mon, 26 Oct 2020 18:19:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c6YDidei" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1783973AbgJZSTT (ORCPT ); Mon, 26 Oct 2020 14:19:19 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45454 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1783966AbgJZSTT (ORCPT ); Mon, 26 Oct 2020 14:19:19 -0400 Received: by mail-pg1-f196.google.com with SMTP id 19so6503325pge.12; Mon, 26 Oct 2020 11:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0DNJ0t/C1pzRa+JekKOelQmdqY3jAoAvJFAIIwjzcxI=; b=c6YDideimVC9ltOEOo02MEpJTj4DfpF8esGdeorn6b8AKxkF2pvnqUpE2QT2H0erxX JoRwY66KYwZpVjGGuFaiKtUdcK1R875E38C++N6APPb6fh37p/ISu9OpW3OFJs3l55Gc 2BSdnrzHCzSj6cBpdG3Nnhs/EFC+eu7Rh5cO0hesmHY6IW/xm5CVqaWmiCegmyrdUFcf Fsm8Nn6CPL3CZwXwunfBaZPVDe9wuDPlMlYK7mI6LsBq+xxaGzUS0VExrUKeLPbFOQWm 6hNrp5T6GQ3lz0sXYDGDXjxHAr74WIyJhsmVJmkvE9KXA6Lf3VQQOuSzoI+Sr1B7Khjr 3CAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0DNJ0t/C1pzRa+JekKOelQmdqY3jAoAvJFAIIwjzcxI=; b=U0KU0N4M/cAQqhVLU6ypO5Y5AnsOLMUDuF2NBMW0TmK4Y7sW08avof+KsGeyQjTo0+ bmaIBiEgcmmyLRTCwvOAC1sEEERXMsUlVSdQcWqYRcKQ1iZwNk0PbUxKlI9g7EXK99J+ Ufbwva+xNUvO2sSFk8BmTOMFUxQw+2BBvdgT1zB5ttn+625xEGpZNynjENLEYyiB9Qyk v7nbJxTwR4hddekGLEYy4GO//yNr9CMjV1dmoxDJDgLSGdgJuPe4TN/aO0Y2uHJ23ePT JqCSUvWUreWu2EG7MfxC9+KenMef/keEI/gOH+3FESKztJpunuxV4nEBhhZ5JobroAd1 AKPA== X-Gm-Message-State: AOAM531iGl4MiDE5sqqIh8jGuNlBXlrSyFkpyY7HBXBjK5arNSCB+/kz KyQwmlpf1ZEIL3MzPIBkrWO1bGJFhgxj5LP6 X-Google-Smtp-Source: ABdhPJxICrpTjoswgcTyvvddScL1O78vUFhyOoRXNVbMst8q0gBSG2wFlklT73LGt3dE4sOW1OvFKw== X-Received: by 2002:a63:4c55:: with SMTP id m21mr18174458pgl.305.1603736357935; Mon, 26 Oct 2020 11:19:17 -0700 (PDT) Received: from [192.168.86.81] ([106.51.240.100]) by smtp.gmail.com with ESMTPSA id q13sm12604702pfg.3.2020.10.26.11.19.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 11:19:16 -0700 (PDT) Subject: Re: [PATCH v2 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature To: Iurii Zaikin Cc: Brendan Higgins , Shuah Khan , Marco Elver , Theodore Ts'o , Andreas Dilger , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Ext4 Developers List References: <20201023150536.282568-1-98.arpi@gmail.com> <20201023150634.282631-1-98.arpi@gmail.com> From: Arpitha Raghunandan <98.arpi@gmail.com> Message-ID: Date: Mon, 26 Oct 2020 23:49:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 26/10/20 11:41 pm, Iurii Zaikin wrote: >> +static struct timestamp_expectation test_data[] = { > Can you mark this and the rest of the hardcoded values as the const they are? > Sure, I will make this change for the next version.