archive mirror
 help / color / mirror / Atom feed
From: Reinette Chatre <>
To: Shaopeng Tan <>,
	Fenghua Yu <>, Shuah Khan <>
Cc: <>, <>
Subject: Re: [PATCH v2 1/5] selftests/resctrl: Kill the child process created by fork() when the SIGTERM signal comes
Date: Thu, 6 Jan 2022 15:46:56 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Shaopeng Tan, 

On 12/13/2021 2:01 AM, Shaopeng Tan wrote:
> In kselftest framework there is a limited time for each sub test,
> when the time limit comes SIGTEM signal will be sent to sub test by


> "timeout --foregroup <seconds>" command.


This is a bit confusing though since it mentions that the "timeout" utility
is called after the test times out. Perhaps you can just describe that, if
present, the test is run using the timeout utility and it will
send SIGTERM to the test upon timeout.

> In resctrl_tests, fork() is used to create a child process.
> This commit ensures child process to be killed before parent process

Especially since I know you are planning more changes in the x86 area
where this is enforced more strictly, please do get into the habit of
describing your changes in imperative mood. Please search for
"This patch" in Documentation/process/submitting-patches.rst (your
usage of "This commit" is equivalent to "This patch") for more details.

Please address this in all your patches where "This commit" is frequently

> exiting if SIGTERM signal comes.
> Signed-off-by: Shaopeng Tan <>
> ---
>  tools/testing/selftests/resctrl/resctrl_val.c | 1 +
>  1 file changed, 1 insertion(+)
> diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
> index 95224345c78e..b32b96356ec7 100644
> --- a/tools/testing/selftests/resctrl/resctrl_val.c
> +++ b/tools/testing/selftests/resctrl/resctrl_val.c
> @@ -678,6 +678,7 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param)
>  	sigemptyset(&sigact.sa_mask);
>  	sigact.sa_flags = SA_SIGINFO;
>  	if (sigaction(SIGINT, &sigact, NULL) ||
> +	    sigaction(SIGTERM, &sigact, NULL) ||
>  	    sigaction(SIGHUP, &sigact, NULL)) {
>  		perror("# sigaction");
>  		ret = errno;

The change looks good. Since this snippet is preceded with a comment
that describes its usage you could also update it with the expanded
use of the kselftest framework.


  reply	other threads:[~2022-01-06 23:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 10:01 [PATCH v2 0/5] selftests/resctrl: Add resctrl_tests into kselftest set Shaopeng Tan
2021-12-13 10:01 ` [PATCH v2 1/5] selftests/resctrl: Kill the child process created by fork() when the SIGTERM signal comes Shaopeng Tan
2022-01-06 23:46   ` Reinette Chatre [this message]
2021-12-13 10:01 ` [PATCH v2 2/5] selftests/resctrl: Make resctrl_tests run using kselftest framework Shaopeng Tan
2022-01-06 23:48   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 3/5] selftests/resctrl: Add license to resctrl_test Makefile Shaopeng Tan
2022-01-06 23:49   ` Reinette Chatre
2021-12-13 10:01 ` [PATCH v2 4/5] selftests/resctrl: Change default limited time to 120 seconds for resctrl_tests Shaopeng Tan
2022-01-06 23:49   ` Reinette Chatre
2022-01-21  7:59     ` tan.shaopeng
2022-01-21 18:06       ` Reinette Chatre
2022-01-24  8:07         ` tan.shaopeng
2021-12-13 10:01 ` [PATCH v2 5/5] selftests/resctrl: Return KSFT_SKIP(4) if resctrlfile system is not supported or resctrl is not run as root Shaopeng Tan
2022-01-06 23:54   ` Reinette Chatre
2022-01-04  9:35 ` [PATCH v2 0/5] selftests/resctrl: Add resctrl_tests into kselftest set tan.shaopeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).