linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Cristian Marussi <cristian.marussi@arm.com>,
	linux-kselftest@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: dave.martin@arm.com, shuah <shuah@kernel.org>
Subject: Re: [PATCH 1/2] kselftest: add capability to skip chosen TARGETS
Date: Wed, 25 Sep 2019 13:36:04 -0600	[thread overview]
Message-ID: <e8848069-124d-a236-30c9-b8915471db16@kernel.org> (raw)
In-Reply-To: <20190925132421.23572-1-cristian.marussi@arm.com>

On 9/25/19 7:24 AM, Cristian Marussi wrote:
> Let the user specify an optional TARGETS skiplist through the new optional
> SKIP_TARGETS Makefile variable.
> 
> It is easier to skip at will a reduced and well defined list of possibly
> problematic targets with SKIP_TARGETS then to provide a partially stripped
> down list of good targets using the usual TARGETS variable.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
>   tools/testing/selftests/Makefile | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 25b43a8c2b15..103936faa46d 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -132,6 +132,10 @@ else
>   		ARCH=$(ARCH) -C $(top_srcdir) headers_install
>   endif
>   
> +# User can optionally provide a TARGETS skiplist.
> +SKIP_TARGETS ?=
> +TARGETS := $(filter-out $(SKIP_TARGETS), $(TARGETS))
> +
>   all: khdr
>   	@for TARGET in $(TARGETS); do		\
>   		BUILD_TARGET=$$BUILD/$$TARGET;	\
> 

Thanks for doing this. This looks good to me. Would you like to
update the documentation file?

thanks,
-- Shuah

  parent reply	other threads:[~2019-09-25 19:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 13:24 [PATCH 1/2] kselftest: add capability to skip chosen TARGETS Cristian Marussi
2019-09-25 13:24 ` [PATCH 2/2] kselftest: exclude failed TARGETS from runlist Cristian Marussi
2019-09-25 19:36   ` shuah
2019-09-25 19:36 ` shuah [this message]
2019-09-26  9:24   ` [PATCH 1/2] kselftest: add capability to skip chosen TARGETS Cristian Marussi
2019-09-25 20:20 ` Tim.Bird
2019-09-26  9:26   ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8848069-124d-a236-30c9-b8915471db16@kernel.org \
    --to=shuah@kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=dave.martin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).