linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	jaswinder.singh@linaro.org, shuah <shuah@kernel.org>
Subject: Re: [BUGFIX PATCH 0/5] selftests: Fixes for 32bit arch
Date: Fri, 18 Oct 2019 15:45:56 -0600	[thread overview]
Message-ID: <ebd87597-9a1e-7d16-2dfb-5bd421383816@kernel.org> (raw)
In-Reply-To: <157046101671.20724.9561877942986463668.stgit@devnote2>

On 10/7/19 9:10 AM, Masami Hiramatsu wrote:
> Hi,
> 
> Here are some patches to fix some warnings/issues on 32bit arch
> (e.g. arm).
> 
> When I built the ksefltest on arm, I hit some 32bit related warnings.
> Here are the patches to fix those issues.
> 
> 
>   - [1/5] va_max was set 2^32 even on 32bit arch. This can make
>          va_max == 0 and always fail. Make it 3GB on 32bit.
>   - [2/5] Some VM tests requires 64bit user space, which should
>          not run on 32bit arch.
>   - [3/5] For counting the size of large file, we should use
>          size_t instead of unsinged long.
>   - [4/5] Gcc warns printf format for size_t and int64_t on
>          32bit arch. Use %llu and cast it.
>   - [5/5] Gcc warns __u64 and pointer type castings. It should
>          once translated to unsigned long.
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (5):
>        selftests: proc: Make va_max 3GB on 32bit arch
>        selftests: vm: Build/Run 64bit tests only on 64bit arch
>        selftests: net: Use size_t and ssize_t for counting file size
>        selftests: net: Fix printf format warnings on arm
>        selftests: sync: Fix cast warnings on arm
> 
> 
>   tools/testing/selftests/net/so_txtime.c            |    4 ++--
>   tools/testing/selftests/net/tcp_mmap.c             |    8 ++++----
>   tools/testing/selftests/net/udpgso.c               |    3 ++-
>   tools/testing/selftests/net/udpgso_bench_tx.c      |    3 ++-
>   .../selftests/proc/proc-self-map-files-002.c       |   11 ++++++++++-
>   tools/testing/selftests/sync/sync.c                |    6 +++---
>   tools/testing/selftests/vm/Makefile                |    5 +++++
>   tools/testing/selftests/vm/run_vmtests             |   10 ++++++++++
>   8 files changed, 38 insertions(+), 12 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
> 

Hi Masami,

I would love to pull these in. But looks like these are spread out
across several sub-systems.

There are some comments on vm patch. Do you mind sending them again
cc'ing everybody on the cover-letter. Looks like these are getting
lost in the noise.

thanks,
-- Shuah

  parent reply	other threads:[~2019-10-18 21:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 15:10 [BUGFIX PATCH 0/5] selftests: Fixes for 32bit arch Masami Hiramatsu
2019-10-07 15:10 ` [BUGFIX PATCH 1/5] selftests: proc: Make va_max 3GB on " Masami Hiramatsu
2019-10-08 17:59   ` Alexey Dobriyan
2019-10-09  2:49     ` Masami Hiramatsu
2019-10-07 15:10 ` [BUGFIX PATCH 2/5] selftests: vm: Build/Run 64bit tests only on 64bit arch Masami Hiramatsu
2019-10-07 15:10 ` [BUGFIX PATCH 3/5] selftests: net: Use size_t and ssize_t for counting file size Masami Hiramatsu
2019-10-07 15:10 ` [BUGFIX PATCH 4/5] selftests: net: Fix printf format warnings on arm Masami Hiramatsu
2019-10-07 15:11 ` [BUGFIX PATCH 5/5] selftests: sync: Fix cast " Masami Hiramatsu
2019-10-18 21:45 ` shuah [this message]
2019-10-21  7:24   ` [BUGFIX PATCH 0/5] selftests: Fixes for 32bit arch Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebd87597-9a1e-7d16-2dfb-5bd421383816@kernel.org \
    --to=shuah@kernel.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).