From: shaozhengchao <shaozhengchao@huawei.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Victor Nogueira <victor@mojatatu.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"shuah@kernel.org" <shuah@kernel.org>,
"weiyongjun (A)" <weiyongjun1@huawei.com>,
yuehaibing <yuehaibing@huawei.com>
Subject: RE: [PATCH net-next,v2] selftests/tc-testing: update qdisc/cls/action features in config
Date: Fri, 30 Sep 2022 13:12:13 +0000 [thread overview]
Message-ID: <ed6cfa6055a94f0fa2bc98d728a9cd97@huawei.com> (raw)
In-Reply-To: <CAM0EoMnp6T6D3p=HjcH+SXha-vMphHRL9eTEKcRaseBDaODBXA@mail.gmail.com>
Hi Jamal:
My apologise. I will be more careful before sending patch.
Thanks to Victor and you for the review.
Zhengchao Shao
-----Original Message-----
From: Jamal Hadi Salim [mailto:jhs@mojatatu.com]
Sent: Friday, September 30, 2022 6:25 PM
To: Victor Nogueira <victor@mojatatu.com>
Cc: shaozhengchao <shaozhengchao@huawei.com>; netdev@vger.kernel.org; linux-kselftest@vger.kernel.org; xiyou.wangcong@gmail.com; jiri@resnulli.us; shuah@kernel.org; weiyongjun (A) <weiyongjun1@huawei.com>; yuehaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH net-next,v2] selftests/tc-testing: update qdisc/cls/action features in config
Please double check your work by testing it before submitting so we can save some cycles in reviewing. Those typos means your last commit was not tested.
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
On Thu, Sep 29, 2022 at 8:22 PM Victor Nogueira <victor@mojatatu.com> wrote:
>
> On Thu, Sep 29, 2022 at 1:11 AM Zhengchao Shao <shaozhengchao@huawei.com> wrote:
> >
> > Since three patchsets "add tc-testing test cases", "refactor
> > duplicate codes in the tc cls walk function", and "refactor
> > duplicate codes in the qdisc class walk function" are merged to
> > net-next tree, the list of supported features needs to be updated in config file.
> >
> > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>
> Reviewed-by: Victor Nogueira <victor@mojatatu.com>
next prev parent reply other threads:[~2022-09-30 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 4:19 [PATCH net-next,v2] selftests/tc-testing: update qdisc/cls/action features in config Zhengchao Shao
2022-09-30 0:21 ` Victor Nogueira
2022-09-30 10:24 ` Jamal Hadi Salim
2022-09-30 13:12 ` shaozhengchao [this message]
2022-10-01 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6cfa6055a94f0fa2bc98d728a9cd97@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=victor@mojatatu.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).