linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Muckle <smuckle@google.com>
To: Brendan Higgins <brendanhiggins@google.com>,
	David Gow <davidgow@google.com>
Cc: Daniel Latypov <dlatypov@google.com>,
	Kees Cook <keescook@chromium.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Joe Fradley <joefradley@google.com>
Subject: Re: [RFC PATCH 0/2] kunit: Support redirecting function calls
Date: Fri, 15 Apr 2022 14:44:27 -0700	[thread overview]
Message-ID: <f496b0c6-ad94-1837-1edd-3f6f9c00b927@google.com> (raw)
In-Reply-To: <f65c2381-1e9c-5945-7672-848d1826532d@google.com>

+Joe Fradley who is also looking at KUnit with Android.

On 4/15/22 14:43, Steve Muckle wrote:
> On 4/4/22 13:13, Brendan Higgins wrote:
>> On Fri, Mar 18, 2022 at 9:22 AM Steven Rostedt <rostedt@goodmis.org> 
>> wrote:
>>>
>>> On Fri, 18 Mar 2022 10:13:12 +0800
>>> David Gow <davidgow@google.com> wrote:
>>>
>>>> Does either (or both) of these features sound useful, and is this
>>>> sort-of API the right model? (Personally, I think there's a reasonable
>>>> scope for both.) Is anything obviously missing or wrong? Do the names,
>>>> descriptions etc. make any sense?
>>>
>>> Obviously I'm biased toward the ftrace solution ;-)
>>
>> Personally, I like providing both - as long as we can keep the
>> interface the same.
>>
>> Ftrace is less visually invasive, but it is also less flexible in
>> capabilities, and requires substantial work to support on new
>> architectures.
> 
> The general feature looks useful to me. I'm not sure the ftrace based 
> API is worth it given it is only offering a visual improvement and has 
> some drawbacks compared to the other implementation (won't work with 
> inline functions, dependencies on other features). Livepatch is absent 
> on arm64 which mostly rules it out for my purposes (Android Generic 
> Kernel Image testing).
> 
> cheers,
> Steve

  reply	other threads:[~2022-04-15 21:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18  2:13 [RFC PATCH 0/2] kunit: Support redirecting function calls David Gow
2022-03-18  2:13 ` [RFC PATCH 1/2] kunit: Expose 'static stub' API to redirect functions David Gow
2022-04-04 20:16   ` Brendan Higgins
2022-04-15 22:05     ` Steve Muckle
2022-05-04 20:35   ` Daniel Latypov
2022-05-04 20:42     ` Brendan Higgins
2022-05-04 21:16       ` Daniel Latypov
2022-03-18  2:13 ` [RFC PATCH 2/2] kunit: expose ftrace-based API for stubbing out functions during tests David Gow
2022-04-04 20:17   ` Brendan Higgins
2022-04-04 21:13   ` Daniel Latypov
2022-03-18 13:21 ` [RFC PATCH 0/2] kunit: Support redirecting function calls Steven Rostedt
2022-04-04 20:13   ` Brendan Higgins
2022-04-15 21:43     ` Steve Muckle
2022-04-15 21:44       ` Steve Muckle [this message]
2022-04-04 20:14 ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f496b0c6-ad94-1837-1edd-3f6f9c00b927@google.com \
    --to=smuckle@google.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=joefradley@google.com \
    --cc=keescook@chromium.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).