From: Shuah Khan <skhan@linuxfoundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: shuah@kernel.org, akpm@linux-foundation.org,
sabyasachi.linux@gmail.com, jrdr.linux@gmail.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"skh >> Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: proc: Fix _GNU_SOURCE redefined build warns
Date: Tue, 24 Sep 2019 14:05:19 -0600 [thread overview]
Message-ID: <f6c20b9b-4984-f865-3698-70b61bcd4be0@linuxfoundation.org> (raw)
In-Reply-To: <20190924195253.GA2633@avx2>
On 9/24/19 1:52 PM, Alexey Dobriyan wrote:
> On Tue, Sep 24, 2019 at 12:19:10PM -0600, Shuah Khan wrote:
>> Fix the following _GNU_SOURCE redefined build warns:
>>
>> proc-loadavg-001.c:17: warning: "_GNU_SOURCE" redefined
>> proc-self-syscall.c:16: warning: "_GNU_SOURCE" redefined
>> proc-uptime-002.c:18: warning: "_GNU_SOURCE" redefined
>
>> +#ifndef _GNU_SOURCE
>> #define _GNU_SOURCE
>> +#endif
>
> Why are you doing this.
>
> There are 140 redefinitions of _GNU_SOURCE
>
Is there something wrong with getting rid of this warning?
thanks,
-- Shuah
prev parent reply other threads:[~2019-09-24 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 18:19 [PATCH v2] selftests: execveat: Fix _GNU_SOURCE redefined build warn Shuah Khan
2019-09-24 18:19 ` [PATCH] selftests: proc: Fix _GNU_SOURCE redefined build warns Shuah Khan
2019-09-24 19:52 ` Alexey Dobriyan
2019-09-24 20:05 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6c20b9b-4984-f865-3698-70b61bcd4be0@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sabyasachi.linux@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).