From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09F9C388F9 for ; Tue, 27 Oct 2020 20:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C1CB2222C for ; Tue, 27 Oct 2020 20:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603832312; bh=0E9vKiVVj8Sr0vK/ZckWDe2HfMwvPPcQYjncrVRGPSE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=X0B8Om6c9oYAuZHMDEYczHGjDeRSuvNax8gnkrKTPBx//7aRZJq4ftzY3XQD5aLqE gqI2JZ2hdr//NhepLfvi7+vD5dxHY/Bq9szg8JLVxZ5r0T6pJ6grOmSu9yKxKz51o/ fPeTO/IpijTH/ntvTKroMgBXlYABUmmId3z4pgkY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S373490AbgJ0U63 (ORCPT ); Tue, 27 Oct 2020 16:58:29 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:44420 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S373486AbgJ0U63 (ORCPT ); Tue, 27 Oct 2020 16:58:29 -0400 Received: by mail-il1-f195.google.com with SMTP id z2so2767263ilh.11 for ; Tue, 27 Oct 2020 13:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mCBo/dw5+eCxlwInuX3ibBdG6i4KroGcWXBgc9MM9yk=; b=E6btr2a3h9jsRHGQAlpxQPGwcSUp/ZTRSB+1EQ+uSsE1eSxQks6bnsMcVHZDIBgtLu 6iE3V6yfWRGc3dDB+Vfw2osZrSe3oBhoahVZNYjWvUNgIYfxyjlw6Frz39/kQRp8VGQ4 QTB7DLORAkPmjopVOXTh6JhRblGV9O1zz0rqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mCBo/dw5+eCxlwInuX3ibBdG6i4KroGcWXBgc9MM9yk=; b=V032JCnOrdNa69n8LbNh14TrSMDA5Yj+j1p0nUu8U0FQdyKuRcWJchi3KJ8ms11ybW zEX4YNWXJGJV+qVbpOxBZcxWI490zu960j1x+0Eqvr2LR565THuWIGzXVgDD7ExyP6Ky picBBJj6IO7+sKZrwnorEI9ExB9Qp1lB8vRbhFbYIa2XgmrFr+2rz0QAi9hlzfGVFRnr 1QJJBVgJ3CJWnLrXVYPi7hiShOibhLi+/pcmx47cXXgFk399A50/cekOwfjvj1Tca5sH SVt1E92M2qRuZymNyul8o9/o5SZe1rPDOuhLMNW7kvWUV+XxkFiOE8xNBYM6DIgsS23f Hw6w== X-Gm-Message-State: AOAM533QvP8VOrC5MTWR2Ul6yHEGUe82DS+9MzPpzZ3Nq9eZNNb6qGAj B10ZuTnojdeRljmtCInOQ7U1+Q== X-Google-Smtp-Source: ABdhPJweLgguNJyriq0XoknCDhp82gHA7tUeIicg3wQa9XK+nHNdeoRTCw8tWWL9lpvo9AuJmWf8Eg== X-Received: by 2002:a92:844b:: with SMTP id l72mr3178687ild.244.1603832307794; Tue, 27 Oct 2020 13:58:27 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id f85sm1512866ill.39.2020.10.27.13.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 13:58:27 -0700 (PDT) Subject: Re: [PATCH v3 03/21] selftests/resctrl: Fix typo in help text To: Fenghua Yu , Shuah Khan , Reinette Chatre , Tony Luck , Babu Moger , James Morse , Borislav Petkov , Thomas Gleixner , Ravi V Shankar Cc: linux-kselftest , linux-kernel , Shuah Khan References: <20201020235126.1871815-1-fenghua.yu@intel.com> <20201020235126.1871815-4-fenghua.yu@intel.com> From: Shuah Khan Message-ID: Date: Tue, 27 Oct 2020 14:58:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201020235126.1871815-4-fenghua.yu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/20/20 5:51 PM, Fenghua Yu wrote: > From: Reinette Chatre > > Add a missing newline to the help text printed and fixup the next line > to line it up to previous line for improved readability. > > Fixes: 78941183d1b1 ("selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest") > Signed-off-by: Reinette Chatre > Signed-off-by: Fenghua Yu > --- > tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c > index 35a91cab1b88..b2a560c0c5dc 100644 > --- a/tools/testing/selftests/resctrl/resctrl_tests.c > +++ b/tools/testing/selftests/resctrl/resctrl_tests.c > @@ -37,8 +37,8 @@ void detect_amd(void) > static void cmd_help(void) > { > printf("usage: resctrl_tests [-h] [-b \"benchmark_cmd [options]\"] [-t test list] [-n no_of_bits]\n"); > - printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT"); > - printf("\t default benchmark is builtin fill_buf\n"); > + printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT\n"); > + printf("\t default benchmark is builtin fill_buf\n"); > printf("\t-t test list: run tests specified in the test list, "); > printf("e.g. -t mbm, mba, cmt, cat\n"); > printf("\t-n no_of_bits: run cache tests using specified no of bits in cache bit mask\n"); > The commit summary is misleading. It isn't typo. You are adding a space to make the message correct? thanks, -- Shuah