Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
From: Palmer Dabbelt <palmerdabbelt@google.com>
To: vincent.chen@sifive.com
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	mathieu.desnoyers@efficios.com, vincent.chen@sifive.com,
	linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 0/3] riscv: add support for restartable sequence 
Date: Mon, 13 Jan 2020 10:47:29 -0800 (PST)
Message-ID: <mhng-b7d41554-17f9-4303-82b7-6d576fc19a9a@palmerdabbelt-glaptop> (raw)
In-Reply-To: <1572919114-3886-1-git-send-email-vincent.chen@sifive.com>

On Mon, 04 Nov 2019 17:58:31 PST (-0800), vincent.chen@sifive.com wrote:
> Add RSEQ, restartable sequence, support and related selftest to RISCV.
> The Kconfig option HAVE_REGS_AND_STACK_ACCESS_API is also required by
> RSEQ because RSEQ will modify the content of pt_regs.sepc through
> instruction_pointer_set() during the fixup procedure. In order to select
> the config HAVE_REGS_AND_STACK_ACCESS_API, the missing APIs for accessing
> pt_regs are also added in this patch set.
>
> The relevant RSEQ tests in kselftest require the Binutils patch "RISC-V:
> Fix linker problems with TLS copy relocs" to avoid placing
> PREINIT_ARRAY and TLS variable of librseq.so at the same address.
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=3e7bd7f24146f162565edf878840449f36a8d974
> A segmental fault will happen if the Binutils misses this patch.
>
>
>
> Vincent Chen (3):
>   riscv: add required functions to enable HAVE_REGS_AND_STACK_ACCESS_API
>   riscv: Add support for restartable sequence
>   rseq/selftests: Add support for riscv
>
>  arch/riscv/Kconfig                        |   2 +
>  arch/riscv/include/asm/ptrace.h           |  29 +-
>  arch/riscv/kernel/entry.S                 |   4 +
>  arch/riscv/kernel/ptrace.c                |  99 +++++
>  arch/riscv/kernel/signal.c                |   3 +
>  tools/testing/selftests/rseq/param_test.c |  23 ++
>  tools/testing/selftests/rseq/rseq-riscv.h | 622 ++++++++++++++++++++++++++++++
>  tools/testing/selftests/rseq/rseq.h       |   2 +
>  8 files changed, 783 insertions(+), 1 deletion(-)
>  create mode 100644 tools/testing/selftests/rseq/rseq-riscv.h

This, with Paul's updated patch 1, isn't building on my end:

In file included from <command-line>:
arch/riscv/kernel/ptrace.c:137:18: error: ‘struct pt_regs’ has no member named ‘sepc’; did you mean ‘epc’?
  REG_OFFSET_NAME(sepc),
                  ^~~~
././include/linux/compiler_types.h:129:57: note: in definition of macro ‘__compiler_offsetof’
 #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
                                                         ^
arch/riscv/kernel/ptrace.c:133:51: note: in expansion of macro ‘offsetof’
 #define REG_OFFSET_NAME(r) {.name = #r, .offset = offsetof(struct pt_regs, r)}
                                                   ^~~~~~~~
arch/riscv/kernel/ptrace.c:137:2: note: in expansion of macro ‘REG_OFFSET_NAME’
  REG_OFFSET_NAME(sepc),
  ^~~~~~~~~~~~~~~
arch/riscv/kernel/ptrace.c:169:18: error: ‘struct pt_regs’ has no member named ‘sstatus’; did you mean ‘status’?
  REG_OFFSET_NAME(sstatus),
                  ^~~~~~~
././include/linux/compiler_types.h:129:57: note: in definition of macro ‘__compiler_offsetof’
 #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
                                                         ^
arch/riscv/kernel/ptrace.c:133:51: note: in expansion of macro ‘offsetof’
 #define REG_OFFSET_NAME(r) {.name = #r, .offset = offsetof(struct pt_regs, r)}
                                                   ^~~~~~~~
arch/riscv/kernel/ptrace.c:169:2: note: in expansion of macro ‘REG_OFFSET_NAME’
  REG_OFFSET_NAME(sstatus),
  ^~~~~~~~~~~~~~~
arch/riscv/kernel/ptrace.c:170:18: error: ‘struct pt_regs’ has no member named ‘sbadaddr’; did you mean ‘badaddr’?
  REG_OFFSET_NAME(sbadaddr),
                  ^~~~~~~~
././include/linux/compiler_types.h:129:57: note: in definition of macro ‘__compiler_offsetof’
 #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
                                                         ^
arch/riscv/kernel/ptrace.c:133:51: note: in expansion of macro ‘offsetof’
 #define REG_OFFSET_NAME(r) {.name = #r, .offset = offsetof(struct pt_regs, r)}
                                                   ^~~~~~~~
arch/riscv/kernel/ptrace.c:170:2: note: in expansion of macro ‘REG_OFFSET_NAME’
  REG_OFFSET_NAME(sbadaddr),
  ^~~~~~~~~~~~~~~
arch/riscv/kernel/ptrace.c:171:18: error: ‘struct pt_regs’ has no member named ‘scause’; did you mean ‘cause’?
  REG_OFFSET_NAME(scause),
                  ^~~~~~
././include/linux/compiler_types.h:129:57: note: in definition of macro ‘__compiler_offsetof’
 #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
                                                         ^
arch/riscv/kernel/ptrace.c:133:51: note: in expansion of macro ‘offsetof’
 #define REG_OFFSET_NAME(r) {.name = #r, .offset = offsetof(struct pt_regs, r)}
                                                   ^~~~~~~~
arch/riscv/kernel/ptrace.c:171:2: note: in expansion of macro ‘REG_OFFSET_NAME’
  REG_OFFSET_NAME(scause),

      parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  1:58 Vincent Chen
2019-11-05  1:58 ` [PATCH 1/3] riscv: add required functions to enable HAVE_REGS_AND_STACK_ACCESS_API Vincent Chen
2019-11-21 20:29   ` Paul Walmsley
2019-11-21 22:32     ` Paul Walmsley
2019-11-26 12:48       ` Vincent Chen
2019-11-05  1:58 ` [PATCH 2/3] riscv: Add support for restartable sequence Vincent Chen
2019-11-05  1:58 ` [PATCH 3/3] rseq/selftests: Add support for riscv Vincent Chen
2020-01-13 18:47 ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-b7d41554-17f9-4303-82b7-6d576fc19a9a@palmerdabbelt-glaptop \
    --to=palmerdabbelt@google.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paul.walmsley@sifive.com \
    --cc=vincent.chen@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git