From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF1AC433DF for ; Mon, 8 Jun 2020 14:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 042072053B for ; Mon, 8 Jun 2020 14:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="IuwnBwur" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729989AbgFHOeo (ORCPT ); Mon, 8 Jun 2020 10:34:44 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:54668 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729938AbgFHOeo (ORCPT ); Mon, 8 Jun 2020 10:34:44 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 058EYdI4052568; Mon, 8 Jun 2020 09:34:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1591626879; bh=IvroNvkykC8zcJI+F1zuPF8QbKPd7StRndcYgZ65grA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=IuwnBwurWedFUz+osjjpcYVfPppVNah3HxmzdMBaf6znUGkgbkiiQvykLlLMdds2C Izb00KhJJN3wYPHFpqiEtCYVNEAclTVrsquHlgoK4x+xy9nlS5ZL3asPGrQf7yXp1d zyIS7uDOzvlBEmSBU3I67njqRnG2HsHFKt6vVn9A= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 058EYdFn115128 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Jun 2020 09:34:39 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 8 Jun 2020 09:34:39 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 8 Jun 2020 09:34:39 -0500 Received: from [10.250.52.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 058EYcOV027551; Mon, 8 Jun 2020 09:34:38 -0500 Subject: Re: [PATCH v26 03/15] leds: multicolor: Introduce a multicolor class definition To: Jacek Anaszewski , Pavel Machek CC: , , References: <20200604120504.32425-1-dmurphy@ti.com> <20200604120504.32425-4-dmurphy@ti.com> <20200606155324.GA21130@amd> <92d71058-a75b-fd3f-59b1-5133be1c21b5@ti.com> From: Dan Murphy Message-ID: <02cf192f-1948-74a5-f2ef-6c2146422ecb@ti.com> Date: Mon, 8 Jun 2020 09:34:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Jacek On 6/6/20 2:59 PM, Jacek Anaszewski wrote: > Dan, > > On 6/6/20 6:39 PM, Dan Murphy wrote: >> Pavek >> >> Thanks for the review >> >> On 6/6/20 10:53 AM, Pavel Machek wrote: >>> Hi! >>> >>>> Introduce a multicolor class that groups colored LEDs >>>> within a LED node. >>>> >>>> The multi color class groups monochrome LEDs and allows controlling >>>> two >>>> aspects of the final combined color: hue and lightness. The former is >>>> controlled via the intensity file and the latter is controlled >>>> via brightness file. >>>> >>>> Acked-by: Jacek Anaszewski >>>> Signed-off-by: Dan Murphy >>>> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor >>>> b/Documentation/ABI/testing/sysfs-class-led-multicolor >>>> new file mode 100644 > [...] >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -9533,6 +9533,14 @@ F: Documentation/devicetree/bindings/leds/ >>>>   F:    drivers/leds/ >>>>   F:    include/linux/leds.h >>>> +LED MULTICOLOR FRAMEWORK >>>> +M:    Dan Murphy >>>> +L:    linux-leds@vger.kernel.org >>> I'd like to be mentioned here, too. "M: Pavel Machek >>> ". And I'm not sure if I should be taking MAINTAINER >>> file update through a LED tree. Should definitely go to separate >>> patch. >> >> Oh definitely.  I thought it was implied that you and Jacek are both >> Maintainers as well. >> >> I will add you but will wait to see if Jacek wants to be added. > > Actually I don't think that we need to add this separate entry > for LED multicolor class. This is still under LED subsystem, > and I didn't add anything for LED class flash. We only need this because I am not a maintainer of the LED flash class or the LED class. But since I authored the code it only made sense to add me as a maintainer for this specific class. You are one of the maintainers of the LED subsystem and wrote the Flash class so your maintainer ship is implied and you will be CC'd for all patches. This will not be the case for the multi color class Dan