From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
<mark.rutland@arm.com>, <daniel.thompson@linaro.org>
Cc: <dmurphy@ti.com>, <linux-leds@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] leds: Add control of the voltage/current regulator to the LED core
Date: Wed, 17 Jul 2019 15:23:16 +0200 [thread overview]
Message-ID: <08873dfd-d7b2-9fd2-1aca-c63a7e983e2d@ti.com> (raw)
In-Reply-To: <4ae4d83b-8dee-72e4-3860-dd420a29115e@gmail.com>
Hi Jacek,
On 15/07/2019 22:42, Jacek Anaszewski wrote:
> @@ -80,6 +107,7 @@ static void led_timer_function(struct timer_list *t)
> }
>
> led_set_brightness_nosleep(led_cdev, brightness);
> + __led_handle_regulator(led_cdev, brightness);
> This cannot be called from atomic context since regulator_enable/disable
> use mutex beneath, that can sleep on contention. Therefore this call
> has to be made in two places instead:
>
> __led_set_brightness()
> __led_set_brightness_blocking()
Thanks. I'll fix this in v3.
JJ
next prev parent reply other threads:[~2019-07-17 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 15:56 [PATCH v2 0/2] leds: Add control of the voltage/current regulator to the LED core Jean-Jacques Hiblot
2019-07-15 15:56 ` [PATCH v2 1/2] dt-bindings: leds: document the "power-supply" property Jean-Jacques Hiblot
2019-07-15 18:52 ` Dan Murphy
2019-08-19 11:31 ` Pavel Machek
2019-07-15 15:56 ` [PATCH v2 2/2] leds: Add control of the voltage/current regulator to the LED core Jean-Jacques Hiblot
2019-07-15 18:59 ` Dan Murphy
2019-07-17 13:14 ` Jean-Jacques Hiblot
2019-07-15 20:42 ` Jacek Anaszewski
2019-07-17 13:23 ` Jean-Jacques Hiblot [this message]
2019-07-16 10:50 ` Daniel Thompson
2019-07-17 13:47 ` Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08873dfd-d7b2-9fd2-1aca-c63a7e983e2d@ti.com \
--to=jjhiblot@ti.com \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).