From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E385C76192 for ; Wed, 17 Jul 2019 13:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECA72205F4 for ; Wed, 17 Jul 2019 13:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="rCTktTTy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726081AbfGQNX0 (ORCPT ); Wed, 17 Jul 2019 09:23:26 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:33626 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbfGQNX0 (ORCPT ); Wed, 17 Jul 2019 09:23:26 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x6HDNJfc053821; Wed, 17 Jul 2019 08:23:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1563369799; bh=7w70GvKKtgyFoxwG+WzJCvNRew7k10rVv3rd6Z95nLk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=rCTktTTyWodhfYtJr/j12+hmDxYg2bovIequtwO63+ayqS47UzhSEHpEh0nT4tZGr e4GwNvJ8SSrBRQynqnsUV64I7LyMi2kdZJOnwoUmpey134e7Pt+eX+nQauZemFlBQ0 /qkj9b2I8S19A8pT9ASekkSQ3C0umAA7BQH8n/3g= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x6HDNJDH060743 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 17 Jul 2019 08:23:19 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 17 Jul 2019 08:23:19 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 17 Jul 2019 08:23:19 -0500 Received: from [10.250.98.129] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x6HDNHfr093396; Wed, 17 Jul 2019 08:23:18 -0500 Subject: Re: [PATCH v2 2/2] leds: Add control of the voltage/current regulator to the LED core To: Jacek Anaszewski , , , CC: , , References: <20190715155657.22976-1-jjhiblot@ti.com> <20190715155657.22976-3-jjhiblot@ti.com> <4ae4d83b-8dee-72e4-3860-dd420a29115e@gmail.com> From: Jean-Jacques Hiblot Message-ID: <08873dfd-d7b2-9fd2-1aca-c63a7e983e2d@ti.com> Date: Wed, 17 Jul 2019 15:23:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <4ae4d83b-8dee-72e4-3860-dd420a29115e@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi Jacek, On 15/07/2019 22:42, Jacek Anaszewski wrote: > @@ -80,6 +107,7 @@ static void led_timer_function(struct timer_list *t) > } > > led_set_brightness_nosleep(led_cdev, brightness); > + __led_handle_regulator(led_cdev, brightness); > This cannot be called from atomic context since regulator_enable/disable > use mutex beneath, that can sleep on contention. Therefore this call > has to be made in two places instead: > > __led_set_brightness() > __led_set_brightness_blocking() Thanks. I'll fix this in v3. JJ