Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Oleh Kravchenko <oleg@kaa.org.ua>, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 2/2] leds: add LED driver for EL15203000 board
Date: Tue, 27 Aug 2019 23:18:05 +0200
Message-ID: <09adee48-484b-9486-8d5b-3bc6520dc719@gmail.com> (raw)
In-Reply-To: <a188c74c-66d2-7a62-da1e-1e0c4558ca35@kaa.org.ua>

Oleh,

On 8/27/19 11:11 PM, Oleh Kravchenko wrote:
> Yes it has this include :)
> 
> $ git remote -v
> origin  git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git (fetch)
> origin  git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git (push)
> 
> $ git fetch --all -p
> Fetching origin
> 
> $ git log origin/master -1
> commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b (tag: v5.3-rc1, origin/master, origin/HEAD)
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Sun Jul 21 14:05:38 2019 -0700

You need to checkout for-next branch.

>     Linus 5.3-rc1
> 
> $ grep -R led_init_data --include='*.h'
> 
> returns nothing..
> 
> 27.08.19 23:56, Jacek Anaszewski пише:
>> Hi Oleh,
>>
>> On 8/27/19 10:43 PM, Oleh Kravchenko wrote:
>>> Hello Jacek,
>>>
>>> what status of linux-leds.git?
>>>     git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git
>>>
>>> Is it outdated? Because I have a errors:
>>>     drivers/leds/leds-el15203000.c:234:9: error: variable ‘init_data’ has initializer but incomplete type
>>>       struct led_init_data init_data = {};
>>
>> I've just compiled drivers/leds/leds-aat1290.c driver that contains the
>> same declaration and it went just fine.
>>
>> I know this is trivial, but did you "#include <linux/leds.h>" ?
>>
> 

-- 
Best regards,
Jacek Anaszewski

  reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 20:32 [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Oleh Kravchenko
2019-08-08 20:32 ` [PATCH v4 2/2] leds: add LED driver for EL15203000 board Oleh Kravchenko
2019-08-13 20:28   ` Jacek Anaszewski
2019-08-13 20:37     ` Oleh Kravchenko
2019-08-14 18:18       ` Jacek Anaszewski
2019-08-14 19:46         ` Oleh Kravchenko
2019-08-14 19:57           ` Jacek Anaszewski
2019-08-14 20:16             ` Oleh Kravchenko
2019-08-14 20:53               ` Jacek Anaszewski
2019-08-14 20:58                 ` Oleh Kravchenko
2019-08-17 15:02               ` Pavel Machek
2019-08-20  7:46                 ` Oleh Kravchenko
2019-08-18 13:47   ` Jacek Anaszewski
2019-08-27 20:43     ` Oleh Kravchenko
2019-08-27 20:56       ` Jacek Anaszewski
2019-08-27 21:11         ` Oleh Kravchenko
2019-08-27 21:18           ` Jacek Anaszewski [this message]
2019-08-27 21:26             ` Oleh Kravchenko
2019-08-13 20:31 ` [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Dan Murphy
2019-08-14 19:54   ` Jacek Anaszewski
2019-08-18 13:41 ` Jacek Anaszewski
2019-08-20  7:50   ` Oleh Kravchenko

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09adee48-484b-9486-8d5b-3bc6520dc719@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=oleg@kaa.org.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org linux-leds@archiver.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/ public-inbox