From: qiwuchen55@gmail.com
To: jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com
Cc: linux-leds@vger.kernel.org, chenqiwu <chenqiwu@xiaomi.com>
Subject: [PATCH] leds: use devm_platform_ioremap_resource_byname()
Date: Fri, 14 Feb 2020 23:48:21 +0800 [thread overview]
Message-ID: <1581695301-16604-1-git-send-email-qiwuchen55@gmail.com> (raw)
From: chenqiwu <chenqiwu@xiaomi.com>
Use devm_platform_ioremap_resource_byname() instead of calling
platform_get_resource_byname() and devm_ioremap_resource() separately.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
drivers/leds/leds-cobalt-qube.c | 12 +++---------
drivers/leds/leds-cobalt-raq.c | 12 ++++--------
2 files changed, 7 insertions(+), 17 deletions(-)
diff --git a/drivers/leds/leds-cobalt-qube.c b/drivers/leds/leds-cobalt-qube.c
index ef22e1e..76af9d8 100644
--- a/drivers/leds/leds-cobalt-qube.c
+++ b/drivers/leds/leds-cobalt-qube.c
@@ -36,15 +36,9 @@ static void qube_front_led_set(struct led_classdev *led_cdev,
static int cobalt_qube_led_probe(struct platform_device *pdev)
{
- struct resource *res;
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -EBUSY;
-
- led_port = devm_ioremap(&pdev->dev, res->start, resource_size(res));
- if (!led_port)
- return -ENOMEM;
+ led_port = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(led_port))
+ return PTR_ERR(led_port);
led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT;
writeb(led_value, led_port);
diff --git a/drivers/leds/leds-cobalt-raq.c b/drivers/leds/leds-cobalt-raq.c
index 045c239..8b1317d 100644
--- a/drivers/leds/leds-cobalt-raq.c
+++ b/drivers/leds/leds-cobalt-raq.c
@@ -65,16 +65,11 @@ static void raq_power_off_led_set(struct led_classdev *led_cdev,
static int cobalt_raq_led_probe(struct platform_device *pdev)
{
- struct resource *res;
int retval;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -EBUSY;
-
- led_port = devm_ioremap(&pdev->dev, res->start, resource_size(res));
- if (!led_port)
- return -ENOMEM;
+ led_port = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(led_port))
+ return PTR_ERR(led_port);
retval = led_classdev_register(&pdev->dev, &raq_power_off_led);
if (retval)
@@ -90,6 +85,7 @@ static int cobalt_raq_led_probe(struct platform_device *pdev)
led_classdev_unregister(&raq_power_off_led);
err_null:
+ devm_ioremap_release(&pdev->dev, led_port);
led_port = NULL;
return retval;
--
1.9.1
next reply other threads:[~2020-02-14 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 15:48 qiwuchen55 [this message]
2020-02-26 13:53 ` [PATCH] leds: use devm_platform_ioremap_resource_byname() Pavel Machek
2020-02-26 15:17 ` chenqiwu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581695301-16604-1-git-send-email-qiwuchen55@gmail.com \
--to=qiwuchen55@gmail.com \
--cc=chenqiwu@xiaomi.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).