* [PATCH] leds: leds-nic78bx: handle error checking and error processing
@ 2020-02-14 15:58 qiwuchen55
2020-04-27 9:56 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: qiwuchen55 @ 2020-02-14 15:58 UTC (permalink / raw)
To: jacek.anaszewski, pavel, dmurphy; +Cc: linux-leds, chenqiwu
From: chenqiwu <chenqiwu@xiaomi.com>
Add error checking and error processing for led probe.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
drivers/leds/leds-nic78bx.c | 31 ++++++++++++++++++++++++-------
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/drivers/leds/leds-nic78bx.c b/drivers/leds/leds-nic78bx.c
index f196f52..cc5adf8 100644
--- a/drivers/leds/leds-nic78bx.c
+++ b/drivers/leds/leds-nic78bx.c
@@ -129,24 +129,24 @@ static int nic78bx_probe(struct platform_device *pdev)
if (!led_data)
return -ENOMEM;
- led_data->pdev = pdev;
- platform_set_drvdata(pdev, led_data);
-
io_rc = platform_get_resource(pdev, IORESOURCE_IO, 0);
if (!io_rc) {
+ ret = -EINVAL;
dev_err(dev, "missing IO resources\n");
- return -EINVAL;
+ goto err_get_res;
}
if (resource_size(io_rc) < NIC78BX_USER_LED_IO_SIZE) {
dev_err(dev, "IO region too small\n");
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_res_size;
}
if (!devm_request_region(dev, io_rc->start, resource_size(io_rc),
KBUILD_MODNAME)) {
+ ret = -EBUSY;
dev_err(dev, "failed to get IO region\n");
- return -EBUSY;
+ goto err_request_region;
}
led_data->io_base = io_rc->start;
@@ -157,13 +157,27 @@ static int nic78bx_probe(struct platform_device *pdev)
ret = devm_led_classdev_register(dev, &nic78bx_leds[i].cdev);
if (ret)
- return ret;
+ goto err_led_classdev_register;
}
/* Unlock LED register */
outb(NIC78BX_UNLOCK_VALUE,
led_data->io_base + NIC78BX_LOCK_REG_OFFSET);
+ led_data->pdev = pdev;
+ platform_set_drvdata(pdev, led_data);
+ return 0;
+
+err_led_classdev_register:
+ i -= 1;
+ while (i >= 0)
+ devm_led_classdev_unregister(dev, &nic78bx_leds[i--].cdev);
+ devm_release_region(dev, io_rc->start, resource_size(io_rc));
+err_request_region:
+err_res_size:
+ release_resource(io_rc);
+err_get_res:
+ devm_kfree(dev, led_data);
return ret;
}
@@ -171,6 +185,9 @@ static int nic78bx_remove(struct platform_device *pdev)
{
struct nic78bx_led_data *led_data = platform_get_drvdata(pdev);
+ if (IS_ERR_OR_NULL(led_data))
+ return PTR_ERR(led_data);
+
/* Lock LED register */
outb(NIC78BX_LOCK_VALUE,
led_data->io_base + NIC78BX_LOCK_REG_OFFSET);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: leds-nic78bx: handle error checking and error processing
2020-02-14 15:58 [PATCH] leds: leds-nic78bx: handle error checking and error processing qiwuchen55
@ 2020-04-27 9:56 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2020-04-27 9:56 UTC (permalink / raw)
To: qiwuchen55; +Cc: jacek.anaszewski, dmurphy, linux-leds, chenqiwu
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
Hi!
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> Add error checking and error processing for led probe.
led->LED please.
Ok, I see that error handling there is clearly propblematic.
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
>
> +
> +err_led_classdev_register:
> + i -= 1;
> + while (i >= 0)
> + devm_led_classdev_unregister(dev, &nic78bx_leds[i--].cdev);
> + devm_release_region(dev, io_rc->start, resource_size(io_rc));
> +err_request_region:
> +err_res_size:
> + release_resource(io_rc);
> +err_get_res:
> + devm_kfree(dev, led_data);
> return ret;
But we should not need to do devm_ releasing in the error paths,
right? Core is expected to do that for us... AFAICT only
release_resource() is neccessary... unless it has some kind of devm_
variant.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-27 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 15:58 [PATCH] leds: leds-nic78bx: handle error checking and error processing qiwuchen55
2020-04-27 9:56 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).