Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] leds: trigger: pattern: Switch to using the new API kobj_to_dev()
@ 2021-03-22  2:37 Tian Tao
  2021-04-25 21:38 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-03-22  2:37 UTC (permalink / raw)
  To: pavel; +Cc: linux-leds

Switch to using the new API kobj_to_dev() to fix the below warnning:
./drivers/leds/trigger/ledtrig-pattern.c:336:60-61: WARNING opportunity
for kobj_to_dev()

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/leds/trigger/ledtrig-pattern.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c
index 4d138d5..43a265d 100644
--- a/drivers/leds/trigger/ledtrig-pattern.c
+++ b/drivers/leds/trigger/ledtrig-pattern.c
@@ -333,7 +333,7 @@ static DEVICE_ATTR_RW(hw_pattern);
 static umode_t pattern_trig_attrs_mode(struct kobject *kobj,
 				       struct attribute *attr, int index)
 {
-	struct device *dev = container_of(kobj, struct device, kobj);
+	struct device *dev = kobj_to_dev(kobj);
 	struct led_classdev *led_cdev = dev_get_drvdata(dev);
 
 	if (attr == &dev_attr_repeat.attr || attr == &dev_attr_pattern.attr)
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] leds: trigger: pattern: Switch to using the new API kobj_to_dev()
  2021-03-22  2:37 [PATCH] leds: trigger: pattern: Switch to using the new API kobj_to_dev() Tian Tao
@ 2021-04-25 21:38 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2021-04-25 21:38 UTC (permalink / raw)
  To: Tian Tao; +Cc: linux-leds


[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

On Mon 2021-03-22 10:37:16, Tian Tao wrote:
> Switch to using the new API kobj_to_dev() to fix the below warnning:
> ./drivers/leds/trigger/ledtrig-pattern.c:336:60-61: WARNING opportunity
> for kobj_to_dev()

Thanks, applied.
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22  2:37 [PATCH] leds: trigger: pattern: Switch to using the new API kobj_to_dev() Tian Tao
2021-04-25 21:38 ` Pavel Machek

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git