From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADFEC4332F for ; Mon, 13 Sep 2021 11:20:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDE7D610A5 for ; Mon, 13 Sep 2021 11:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239515AbhIMLVy (ORCPT ); Mon, 13 Sep 2021 07:21:54 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:55536 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239504AbhIMLVx (ORCPT ); Mon, 13 Sep 2021 07:21:53 -0400 Received: from [10.1.22.96] (unknown [10.1.22.96]) by uho.ysoft.cz (Postfix) with ESMTP id AFDC3A6393; Mon, 13 Sep 2021 13:20:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1631532033; bh=VTfjBwSA+tm/qkHHH9rdmUMTuQmZ5GRrsz/L/qmkADc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=kll25NEqXmVe/0eE/fNDEyF7osI3IhaYElCM4xvUT4/phe+dUYWZnSeP3YBDZSMzV wgKMGXobUIsayWFHhb0+Y8kOOBmo53Mc7prcD7GedBphxaKFKIKomjziTyFWn0ZlS0 Pzo6h9ORzHh51atSPUKHOsXe3zHhzxoUKr7wOEZ0= Subject: Re: [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe To: Shawn Guo Cc: Rob Herring , Fabio Estevam , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Pavel Machek , Jacek Anaszewski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-leds@vger.kernel.org References: <20210818070209.1540451-1-michal.vokac@ysoft.com> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: <19c8bb7d-6fe5-3b7d-a8b5-785ba93f7265@ysoft.com> Date: Mon, 13 Sep 2021 13:20:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210818070209.1540451-1-michal.vokac@ysoft.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 18. 08. 21 9:02, Michal Vokáč wrote: > Since the LED multicolor framework support was added in commit > 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > LEDs on this platform stopped working. > > Author of the framework attempted to accommodate this DT to the > framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property > to the lp5562 channel node") but that is not sufficient. A color property > is now required even if the multicolor framework is not used, otherwise > the driver probe fails: > > lp5562: probe of 1-0030 failed with error -22 > > Add the color property to fix this. > > Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > Cc: > Cc: linux-leds@vger.kernel.org > Signed-off-by: Michal Vokáč Hi Shawn, gentle ping on this little series. Thank you, Michal