From: Pavel Machek <pavel@ucw.cz>
To: David Lin <dtwlin@google.com>
Cc: corbet@lwn.net, rpurdie@rpsys.net, jacek.anaszewski@gmail.com,
hdegoede@redhat.com, gregkh@linuxfoundation.org, robh@kernel.org,
romlem@google.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer
Date: Wed, 13 Sep 2017 22:20:32 +0200 [thread overview]
Message-ID: <20170913202032.GA30844@amd> (raw)
In-Reply-To: <20170913175400.42744-1-dtwlin@google.com>
[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]
Hi!
> These patch series add the LED_BRIGHTNESS_FAST flag support for
> ledtrig-transient to use hrtimer so that platforms with high-resolution timer
> support can have better accuracy in the trigger duration timing. The need for
> this support is driven by the fact that Android has removed the timed_ouput [1]
> and is now using led-trigger for handling vibrator control which requires the
> timer to be accurate up to a millisecond. However, this flag support would also
> allow hrtimer to co-exist with the ktimer without causing warning to the
> existing drivers [2].
NAK.
LEDs do not need extra overhead, and vibrator control should not go
through LED subsystem.
Input subsystem includes support for vibrations and force
feedback. Please use that instead.
Pavel
> David Lin (3):
> leds: Replace flags bit shift with BIT() macros
> leds: Add the LED_BRIGHTNESS_FAST flag
> led: ledtrig-transient: add support for hrtimer
>
> Documentation/leds/leds-class.txt | 5 +++
> drivers/leds/trigger/ledtrig-transient.c | 59 +++++++++++++++++++++++++++++---
> include/linux/leds.h | 19 +++++-----
> 3 files changed, 69 insertions(+), 14 deletions(-)
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-09-13 20:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 17:53 [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-09-13 17:53 ` [PATCH v2 1/3] leds: Replace flags bit shift with BIT() macros David Lin
2017-09-14 19:43 ` Jacek Anaszewski
2017-09-13 17:53 ` [PATCH v2 2/3] leds: Add the LED_BRIGHTNESS_FAST flag David Lin
2017-09-13 17:54 ` [PATCH v2 3/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-09-13 20:20 ` Pavel Machek [this message]
2017-09-13 21:20 ` [PATCH v2 0/3] " David Lin
2017-09-13 21:34 ` Pavel Machek
2017-09-14 17:31 ` David Lin
2017-09-14 19:42 ` Pavel Machek
2017-09-14 19:31 ` Jacek Anaszewski
2017-09-14 19:38 ` David Lin
2017-09-14 20:03 ` Jacek Anaszewski
2017-09-14 20:58 ` Vibrations in input vs. LED was " Pavel Machek
2017-09-15 18:34 ` Dmitry Torokhov
2017-09-15 21:55 ` Jacek Anaszewski
2017-09-15 22:30 ` Dmitry Torokhov
2017-09-17 16:41 ` Jacek Anaszewski
2017-09-17 18:22 ` Pavel Machek
2017-09-17 21:15 ` Pavel Machek
2017-09-18 20:50 ` Jacek Anaszewski
2017-09-18 22:29 ` Dmitry Torokhov
2017-09-19 20:45 ` Jacek Anaszewski
2017-09-19 21:07 ` Dmitry Torokhov
2017-09-20 19:31 ` Jacek Anaszewski
2017-09-20 11:29 ` Pavel Machek
2017-09-20 20:08 ` Jacek Anaszewski
2017-10-06 11:48 ` Pavel Machek
2017-10-06 20:57 ` Jacek Anaszewski
2017-09-20 11:26 ` Pavel Machek
2017-09-28 5:03 ` David Lin
2017-09-28 5:43 ` Dmitry Torokhov
2017-09-28 19:22 ` David Lin
2017-10-05 0:40 ` Dmitry Torokhov
2017-09-16 12:59 ` Pavel Machek
2017-09-15 21:55 ` Jacek Anaszewski
2017-09-16 1:58 ` Pavel Machek
2017-09-17 16:41 ` Jacek Anaszewski
2017-09-17 17:50 ` Pavel Machek
2017-09-18 20:43 ` Jacek Anaszewski
2017-09-20 11:15 ` Pavel Machek
2017-09-20 18:44 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913202032.GA30844@amd \
--to=pavel@ucw.cz \
--cc=corbet@lwn.net \
--cc=dtwlin@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=romlem@google.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).