From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver Date: Wed, 19 Dec 2018 23:03:26 +0100 Message-ID: <20181219220326.GA28244@amd> References: <20181219162626.12297-1-dmurphy@ti.com> <20181219162626.12297-3-dmurphy@ti.com> <20181219193455.GA21159@amd> <8740cfd6-a6b5-ad27-313b-984a9febf18a@ti.com> <20181219201047.GA23448@amd> <54f28115-0a7d-8e9c-3bec-6e91fb3981ec@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Return-path: Content-Disposition: inline In-Reply-To: <54f28115-0a7d-8e9c-3bec-6e91fb3981ec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Dan Murphy , robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >I don't think a user needs nor would want to have 24 different LED nodes= with 24 different brightness files. > >Or with the LP5036 that would have 36 LED nodes. > > > >Table 1 in the data sheet shows how the outputs map to the control banks= to the LED registers. >=20 > Some time ago we had discussion with Vesa J=E4=E4skel=E4inen about possib= le > approaches to RGB LEDs [0]. What seemed to be the most suitable > variation of the discussed out-of-tree approach was the "color" property > and array of color triplets defined in Device Tree per each color. >=20 > Please refer to [0] for the details. >=20 > [0] https://lkml.org/lkml/2018/11/9/938 Yes, plus I also have the set of HSV patches somewhere... and they work, but I found out that HSV->RGB conversion results in loss of precision. We may want to do something like that. But we need to do it once, in a driver core. We obviously don't want each driver having different version of RGB support. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwawC4ACgkQMOfwapXb+vLNYACffdYFK7xGKYm+tAfbhDAE5uJs jJ4AoLLb9z0NH5aRd7BxwnfKc5ZK2F4e =YXOP -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--