From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH 2/8] leds: as3645a: Fix misuse of strlcpy Date: Fri, 5 Jul 2019 10:33:22 +0300 Message-ID: <20190705073322.wee52ttghxm2vczn@valkosipuli.retiisi.org.uk> References: <79fe35321ff794dccf1d08b415cee40636fa5fce.1562283944.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <79fe35321ff794dccf1d08b415cee40636fa5fce.1562283944.git.joe@perches.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Jacek Anaszewski , Pavel Machek , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org On Thu, Jul 04, 2019 at 04:57:42PM -0700, Joe Perches wrote: > Probable cut&paste typo - use the correct field size. > > Signed-off-by: Joe Perches Thanks, Joe! Acked-by: Sakari Ailus > --- > drivers/leds/leds-as3645a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c > index 14ab6b0e4de9..050088dff8dd 100644 > --- a/drivers/leds/leds-as3645a.c > +++ b/drivers/leds/leds-as3645a.c > @@ -668,7 +668,7 @@ static int as3645a_v4l2_setup(struct as3645a *flash) > }; > > strlcpy(cfg.dev_name, led->name, sizeof(cfg.dev_name)); > - strlcpy(cfgind.dev_name, flash->iled_cdev.name, sizeof(cfg.dev_name)); > + strlcpy(cfgind.dev_name, flash->iled_cdev.name, sizeof(cfgind.dev_name)); > > flash->vf = v4l2_flash_init( > &flash->client->dev, flash->flash_node, &flash->fled, NULL, -- Kind regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2840CC5B57D for ; Fri, 5 Jul 2019 07:34:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE710218BA for ; Fri, 5 Jul 2019 07:34:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727722AbfGEHeJ (ORCPT ); Fri, 5 Jul 2019 03:34:09 -0400 Received: from retiisi.org.uk ([95.216.213.190]:53892 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfGEHeJ (ORCPT ); Fri, 5 Jul 2019 03:34:09 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id A7F8E634C7F; Fri, 5 Jul 2019 10:33:23 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.89) (envelope-from ) id 1hjIig-0001if-VQ; Fri, 05 Jul 2019 10:33:22 +0300 Date: Fri, 5 Jul 2019 10:33:22 +0300 From: Sakari Ailus To: Joe Perches Cc: Jacek Anaszewski , Pavel Machek , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] leds: as3645a: Fix misuse of strlcpy Message-ID: <20190705073322.wee52ttghxm2vczn@valkosipuli.retiisi.org.uk> References: <79fe35321ff794dccf1d08b415cee40636fa5fce.1562283944.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <79fe35321ff794dccf1d08b415cee40636fa5fce.1562283944.git.joe@perches.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Message-ID: <20190705073322.QqwgZqCOjuLm9jpWOojNAUQVpr4aUx9R5B4k9dMs_Fg@z> On Thu, Jul 04, 2019 at 04:57:42PM -0700, Joe Perches wrote: > Probable cut&paste typo - use the correct field size. > > Signed-off-by: Joe Perches Thanks, Joe! Acked-by: Sakari Ailus > --- > drivers/leds/leds-as3645a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c > index 14ab6b0e4de9..050088dff8dd 100644 > --- a/drivers/leds/leds-as3645a.c > +++ b/drivers/leds/leds-as3645a.c > @@ -668,7 +668,7 @@ static int as3645a_v4l2_setup(struct as3645a *flash) > }; > > strlcpy(cfg.dev_name, led->name, sizeof(cfg.dev_name)); > - strlcpy(cfgind.dev_name, flash->iled_cdev.name, sizeof(cfg.dev_name)); > + strlcpy(cfgind.dev_name, flash->iled_cdev.name, sizeof(cfgind.dev_name)); > > flash->vf = v4l2_flash_init( > &flash->client->dev, flash->flash_node, &flash->fled, NULL, -- Kind regards, Sakari Ailus