From: Nick Stoughton <nstoughton@logitech.com>
To: linux-leds@vger.kernel.org
Cc: Nick Stoughton <nstoughton@logitech.com>
Subject: [PATCH 1/1] leds: leds-lp5562 allow firmware files up to the maximum length
Date: Wed, 17 Jul 2019 14:56:06 -0700 [thread overview]
Message-ID: <20190717215606.3053-2-nstoughton@logitech.com> (raw)
In-Reply-To: <20190717215606.3053-1-nstoughton@logitech.com>
Firmware files are in ASCII, using 2 hex characters per byte. The
maximum length of a firmware string is therefore
16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64
Signed-off-by: Nick Stoughton <nstoughton@logitech.com>
---
drivers/leds/leds-lp5562.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
index 37632fc63741..e00117e3b50d 100644
--- a/drivers/leds/leds-lp5562.c
+++ b/drivers/leds/leds-lp5562.c
@@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip)
{
const struct firmware *fw = chip->fw;
- if (fw->size > LP5562_PROGRAM_LENGTH) {
+ /*
+ * the firmware is encoded in ascii hex character, with 2 chars
+ * per byte
+ */
+ if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) {
dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
fw->size);
return;
--
Nick Stoughton
next prev parent reply other threads:[~2019-07-17 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 21:56 [PATCH 0/1] Resend leds-lp5562 allow firmware files up to the maximum length Nick Stoughton
2019-07-17 21:56 ` Nick Stoughton [this message]
2019-07-17 22:19 ` [PATCH 1/1] leds: " Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717215606.3053-2-nstoughton@logitech.com \
--to=nstoughton@logitech.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).