From: Pavel Machek <pavel@ucw.cz>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, simon@lineageos.org
Cc: jacek.anaszewski@gmail.com, dmurphy@ti.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] leds: an30259a: Fix typo
Date: Sun, 21 Jul 2019 23:42:40 +0200 [thread overview]
Message-ID: <20190721214240.GA13062@amd> (raw)
In-Reply-To: <20190721205955.25317-1-christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
Hi!
> All this file is about an30259a, including the reference to the datasheet
> at the top of the file.
>
> So change the 2 places where an32059a is used instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
I see nothing wrong... But address listed as AUTHOR might be worth
Cc-ing? :-).
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
> an32059a is another chip from panasonic
> ---
> drivers/leds/leds-an30259a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c
> index 1c1f0c8c56f4..37e7c7998972 100644
> --- a/drivers/leds/leds-an30259a.c
> +++ b/drivers/leds/leds-an30259a.c
> @@ -353,7 +353,7 @@ MODULE_DEVICE_TABLE(i2c, an30259a_id);
>
> static struct i2c_driver an30259a_driver = {
> .driver = {
> - .name = "leds-an32059a",
> + .name = "leds-an30259a",
> .of_match_table = of_match_ptr(an30259a_match_table),
> },
> .probe_new = an30259a_probe,
> @@ -364,5 +364,5 @@ static struct i2c_driver an30259a_driver = {
> module_i2c_driver(an30259a_driver);
>
> MODULE_AUTHOR("Simon Shields <simon@lineageos.org>");
> -MODULE_DESCRIPTION("AN32059A LED driver");
> +MODULE_DESCRIPTION("AN30259A LED driver");
> MODULE_LICENSE("GPL v2");
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-07-21 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 20:59 [PATCH] leds: an30259a: Fix typo Christophe JAILLET
2019-07-21 21:42 ` Pavel Machek [this message]
2019-07-22 20:13 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721214240.GA13062@amd \
--to=pavel@ucw.cz \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).