From: Rob Herring <robh@kernel.org>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, mark.rutland@arm.com,
daniel.thompson@linaro.org, dmurphy@ti.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: leds: document new "power-supply" property
Date: Wed, 24 Jul 2019 10:47:57 -0600 [thread overview]
Message-ID: <20190724164757.GA3723@bogus> (raw)
In-Reply-To: <20190708103547.23528-3-jjhiblot@ti.com>
On Mon, Jul 08, 2019 at 12:35:47PM +0200, Jean-Jacques Hiblot wrote:
> Most of the LEDs are powered by a voltage/current regulator. describing in
> the device-tree makes it possible for the LED core to enable/disable it
> when needed.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> Documentation/devicetree/bindings/leds/common.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index 70876ac11367..e093a2b7eb90 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -61,6 +61,11 @@ Optional properties for child nodes:
> - panic-indicator : This property specifies that the LED should be used,
> if at all possible, as a panic indicator.
>
> +- power-supply : A voltage/current regulator used to to power the LED. When a
> + LED is turned off, the LED core disable its regulator. The
> + same regulator can power many LED (or other) devices. It is
> + turned off only when all of its users disabled it.
Not sure this should be common. It wouldn't apply to cases where we have
an LED controller parent nor gpio and pwm LEDs and those are most cases.
Perhaps what makes sense here is an regulator-led binding.
> +
> - trigger-sources : List of devices which should be used as a source triggering
> this LED activity. Some LEDs can be related to a specific
> device and should somehow indicate its state. E.g. USB 2.0
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-07-24 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 10:35 [PATCH 0/2] leds: Add control of the voltage/current regulator to the LED core Jean-Jacques Hiblot
2019-07-08 10:35 ` Jean-Jacques Hiblot
2019-07-08 10:35 ` [PATCH 1/2] " Jean-Jacques Hiblot
2019-07-08 10:35 ` Jean-Jacques Hiblot
2019-07-12 18:49 ` Dan Murphy
2019-07-12 18:49 ` Dan Murphy
2019-07-15 9:01 ` Jean-Jacques Hiblot
2019-07-15 9:24 ` Daniel Thompson
2019-07-15 9:47 ` Jean-Jacques Hiblot
2019-07-15 15:19 ` Daniel Thompson
2019-07-08 10:35 ` [PATCH 2/2] dt-bindings: leds: document new "power-supply" property Jean-Jacques Hiblot
2019-07-08 10:35 ` Jean-Jacques Hiblot
2019-07-12 18:38 ` Dan Murphy
2019-07-12 18:38 ` Dan Murphy
2019-07-24 16:47 ` Rob Herring [this message]
2019-07-25 11:08 ` Jean-Jacques Hiblot
2019-07-26 10:06 ` Daniel Thompson
2019-07-26 22:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724164757.GA3723@bogus \
--to=robh@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).