From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, tony@atomide.com, sre@kernel.org,
nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration
Date: Mon, 19 Aug 2019 12:55:19 +0200 [thread overview]
Message-ID: <20190819105519.GG21072@amd> (raw)
In-Reply-To: <20190813181154.6614-4-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
Hi!
> Allow the full scale current to be configured at init.
> Valid rangles are 5mA->29.8mA.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> @@ -121,6 +125,7 @@ struct lm3532_als_data {
> * @mode - Mode of the LED string
> * @ctrl_brt_pointer - Zone target register that controls the sink
> * @num_leds - Number of LED strings are supported in this array
> + * @full_scale_current - The full-scale current setting for the current sink.
> * @led_strings - The LED strings supported in this array
> * @label - LED label
> */
> @@ -130,8 +135,9 @@ struct lm3532_led {
>
> int control_bank;
> int mode;
> - int ctrl_brt_pointer;
> int num_leds;
> + int ctrl_brt_pointer;
> + int full_scale_current;
> u32 led_strings[LM3532_MAX_CONTROL_BANKS];
> char label[LED_MAX_NAME_SIZE];
> };
No need to move ctrl_brt_pointer... to keep order consistent with docs.
> + fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN /
> + LM3532_FS_CURR_STEP;
The computation is wrong ... needs () AFAICT.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-08-19 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 18:11 [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode Dan Murphy
2019-08-13 18:11 ` [PATCH v2 2/4] leds: lm3532: Fixes for the driver for stability Dan Murphy
2019-08-19 10:48 ` Pavel Machek
2019-08-13 18:11 ` [PATCH v2 3/4] dt: lm3532: Add property for full scale current Dan Murphy
2019-08-19 10:49 ` Pavel Machek
2019-08-13 18:11 ` [PATCH v2 4/4] leds: lm3532: Add full scale current configuration Dan Murphy
2019-08-19 10:55 ` Pavel Machek [this message]
2019-08-20 15:51 ` Dan Murphy
2019-08-20 16:29 ` Pavel Machek
2019-08-20 17:48 ` Dan Murphy
2019-08-19 10:48 ` [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode Pavel Machek
2019-08-20 15:52 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819105519.GG21072@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).